Noissue - Fix messageResponder for Firefox

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 125 matching lines @@
         ext.showOptions(function()
         {
           var subscription = Subscription.fromURL(message.url);
           subscription.title = message.title;
           onFilterChange("addSubscription", subscription);
         });
         break;
       case "app.get":
         if (message.what == "issues")
         {
-          var subscriptionInit = require("subscriptionInit");
+          var subscriptionInit;
+          try
+          {
+            subscriptionInit = require("subscriptionInit");
+          }
+          catch (e)
+          {
+            // Expected exception, this module doesn't exist on Firefox
+          }
+
           var info = require("info");
           callback({
             filterlistsReinitialized: subscriptionInit ? subscriptionInit.reinitialized : false,
             legacySafariVersion: (info.platform == "safari" && (
                 Services.vc.compare(info.platformVersion, "6.0") < 0 ||   // beforeload breaks websites in Safari 5
                 Services.vc.compare(info.platformVersion, "6.1") == 0 ||  // extensions are broken in 6.1 and 7.0
                 Services.vc.compare(info.platformVersion, "7.0") == 0))
           });
         }
         else if (message.what == "doclink")
@@ skipping 191 matching lines @@
         {
           subscription.disabled = false;
           subscription.title = message.title;
           subscription.homepage = message.homepage;
           FilterStorage.addSubscription(subscription);
           if (!subscription.lastDownload)
             Synchronizer.execute(subscription);
         }
         break;
       case "subscriptions.update":
-        var subscriptions = message.url ? [Subscription.fromURL(message.url)] : 
+        var subscriptions = message.url ? [Subscription.fromURL(message.url)] :

[Sebastian Noack, 2016/03/16 13:47:45]

What is the change here?

Anyway, LGTM.

[Wladimir Palant, 2016/03/16 13:57:49]

Trailing whitespace removed, my editor does this automatically.

                             FilterStorage.subscriptions;
         for (var i = 0; i < subscriptions.length; i++)
         {
           var subscription = subscriptions[i];
           if (subscription instanceof DownloadableSubscription)
             Synchronizer.execute(subscription, true);
         }
         break;
       case "subscriptions.isDownloading":
         callback(Synchronizer.isExecuting(message.url));
         break;
     }
   });
 })(this);