Issue 3574 - Move cron setup from class base to module adblockplus

modules/adblockplus/manifests/init.pp

 # == Class: adblockplus
 #
 # The adblockplus class and the associated adblockplus:: namespace are
 # used to integrate Puppet modules with each other, in order to assemble
 # the setups used by the Adblock Plus project.
 #
 # === Parameters:
 #
 # [*authority*]
 #   The authorative domain or zone associated with the current environment,
@@ skipping 58 matching lines @@
       group => 'root',
       mode => 0644,
       notify => Service['cron'],
       owner => 'root';
     '/etc/localtime':
       ensure => 'link',
       target => '/usr/share/zoneinfo/UTC',
       notify => Service['cron'];
   }
 
+  # Explicit resource required only to ensure cron(8) is running;
+  # there is no real requirement for a rationship with another resource
+  service {'cron':
+    ensure => 'running',
+    enable => true,
+  }
+
   # Work around https://issues.adblockplus.org/ticket/3479
   if $::environment == 'development' {
 
     file {
       '/etc/ssh/ssh_host_rsa_key':
         source => 'puppet:///modules/adblockplus/development_host_rsa_key',
         mode => 600,
         notify => Service['ssh'];
       '/etc/ssh/ssh_host_rsa_key.pub':
         source => 'puppet:///modules/adblockplus/development_host_rsa_key.pub',
         mode => 644;
     }
   }
 
   # Fix implicit package dependency Class['apt'] does not properly handle
   Exec['apt_update'] -> Package<|title != 'python-software-properties'|>
 
   # https://projects.puppetlabs.com/issues/4145
   ensure_resource('file', '/etc/ssh/ssh_known_hosts', {
     ensure => 'present',
     mode => 0644,
   })
 
   # See modules/adblockplus/manifests/host.pp
   create_resources('adblockplus::host', $hosts)
 
   # See modules/adblockplus/manifests/user.pp
   create_resources('adblockplus::user', $users)
 }