Issue 3826 - Filter preference change events

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 67 matching lines @@
     pages.forEach(refreshIconAndContextMenu);
   });
 }
 
 FilterNotifier.addListener(function(action)
 {
   if (action == "load" || action == "save")
     refreshIconAndContextMenuForAllPages();
 });
 
-Prefs.onChanged.addListener(function(name)
-{
-  if (name == "shouldShowBlockElementMenu")
-    refreshIconAndContextMenuForAllPages();
-});
+Prefs.on("shouldShowBlockElementMenu", refreshIconAndContextMenuForAllPages);
 
 // This is a hack to speedup loading of the options page on Safari.
 // Once we replaced the background page proxy with message passing
 // this global function should removed.
 function getUserFilters()
 {
   var filters = [];
   var exceptions = [];
 
   for (var i = 0; i < FilterStorage.subscriptions.length; i++)
@@ skipping 104 matching lines @@
   }
 });
 
 // update icon when page changes location
 ext.pages.onLoading.addListener(function(page)
 {
   page.sendMessage({type: "composer.content.finished"});
   refreshIconAndContextMenu(page);
   showNextNotificationForUrl(page.url);
 });