Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 29338588: Issue 3699 - Patch DOM API in order to prevent disabling the injected stylesheet (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Sebastian Noack
Modified:
3 years, 11 months ago
Reviewers:
kzar
Visibility:
Public.

Description

Issue 3699 - Patch DOM API in order to prevent disabling the injected stylesheet

Patch Set 1 #

Patch Set 2 : Use MutationObserver again #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -42 lines) Patch
M include.preload.js View 1 2 chunks +56 lines, -42 lines 4 comments Download

Messages

Total messages: 5
Sebastian Noack
3 years, 11 months ago (2016-03-17 19:48:02 UTC) #1
Sebastian Noack
Given how many ways there are to cause an element being removed from the DOM ...
3 years, 11 months ago (2016-03-18 17:36:15 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29338588/diff/29338656/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29338588/diff/29338656/include.preload.js#newcode361 include.preload.js:361: ' document.documentElement.shadowRoot.getElementById("' + id + '");', (Yes, I know ...
3 years, 11 months ago (2016-03-18 17:58:54 UTC) #3
kzar
I found this code kind of confusing to understand but I think that's because the ...
3 years, 11 months ago (2016-03-18 19:18:32 UTC) #4
Sebastian Noack
3 years, 11 months ago (2016-03-18 19:23:55 UTC) #5
https://codereview.adblockplus.org/29338588/diff/29338656/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29338588/diff/29338656/include.preload.js#...
include.preload.js:373: for (var j = 0; j < methods.length; j++)
On 2016/03/18 19:18:32, kzar wrote:
> Nit: Just re-use the existing `i` variable instead?

I'm not sure whether it's a good idea to make the code here depend on a
unrelated variable declared in the headers of the previous loop.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5