Issue 3836 - Don't set DownloadableSubscription.upgradeRequired in Synchronizer

lib/synchronizer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 221 matching lines @@
           expirationInterval = interval * MILLIS_IN_HOUR;
         else
           expirationInterval = interval * MILLIS_IN_DAY;
       }
     }
 
     let [softExpiration, hardExpiration] = downloader.processExpirationInterval(expirationInterval);
     subscription.softExpiration = Math.round(softExpiration / MILLIS_IN_SECOND);
     subscription.expires = Math.round(hardExpiration / MILLIS_IN_SECOND);
 
-    delete subscription.requiredVersion;
-    delete subscription.upgradeRequired;
     if (minVersion)
-    {
-      let {addonVersion} = require("info");
       subscription.requiredVersion = minVersion;
-      if (Services.vc.compare(minVersion, addonVersion) > 0)
-        subscription.upgradeRequired = true;
-    }
+    else
+      delete subscription.requiredVersion;
 
     // Process filters
     lines.shift();
     let filters = [];
     for (let line of lines)
     {
       line = Filter.normalize(line);
       if (line)
         filters.push(Filter.fromText(line));
     }
@@ skipping 50 matching lines @@
             let data = "[Adblock]\n" + subscription.filters.map((f) => f.text).join("\n");
             redirectCallback("data:text/plain," + encodeURIComponent(data));
           }
         }, false);
         request.send(null);
       }
     }
   },
 };
 Synchronizer.init();