Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338675: Issue 3694 - Introduce class adblockplus::log::processor and role logprocessor (Closed)

Created:
March 18, 2016, 6:08 p.m. by mathias
Modified:
March 21, 2016, 5:12 p.m.
Reviewers:
Fred
CC:
Felix Dahlke, darius
Visibility:
Public.

Description

Issue 3694 - Introduce class adblockplus::log::processor and role logprocessor

Patch Set 1 #

Total comments: 3

Patch Set 2 : Issue 3694 - Addressing feedback from code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
A hiera/roles/logprocessor.yaml View 1 1 chunk +50 lines, -0 lines 0 comments Download
A modules/adblockplus/manifests/log/processor.pp View 1 chunk +38 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
mathias
March 18, 2016, 6:08 p.m. (2016-03-18 18:08:16 UTC) #1
Fred
https://codereview.adblockplus.org/29338675/diff/29338676/hiera/roles/logprocessor.yaml File hiera/roles/logprocessor.yaml (right): https://codereview.adblockplus.org/29338675/diff/29338676/hiera/roles/logprocessor.yaml#newcode46 hiera/roles/logprocessor.yaml:46: fluent-plugin-secure-forward: Do we really need/want this plugin in the ...
March 21, 2016, 4:33 p.m. (2016-03-21 16:33:35 UTC) #2
mathias
https://codereview.adblockplus.org/29338675/diff/29338676/hiera/roles/logprocessor.yaml File hiera/roles/logprocessor.yaml (right): https://codereview.adblockplus.org/29338675/diff/29338676/hiera/roles/logprocessor.yaml#newcode46 hiera/roles/logprocessor.yaml:46: fluent-plugin-secure-forward: On 2016/03/21 16:33:35, Fred wrote: > Do we ...
March 21, 2016, 4:36 p.m. (2016-03-21 16:36:22 UTC) #3
Fred
https://codereview.adblockplus.org/29338675/diff/29338676/hiera/roles/logprocessor.yaml File hiera/roles/logprocessor.yaml (right): https://codereview.adblockplus.org/29338675/diff/29338676/hiera/roles/logprocessor.yaml#newcode46 hiera/roles/logprocessor.yaml:46: fluent-plugin-secure-forward: That suggestion sounds reasonable to me.
March 21, 2016, 4:42 p.m. (2016-03-21 16:42:20 UTC) #4
mathias
March 21, 2016, 4:44 p.m. (2016-03-21 16:44:52 UTC) #5
Fred
March 21, 2016, 4:54 p.m. (2016-03-21 16:54:37 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld