Issue 29338716: Issue 2687 - Don't use Shadow DOM on blogger.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29338716: Issue 2687 - Don't use Shadow DOM on blogger.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 8 months ago by Sebastian Noack

Modified:
3 years, 8 months ago

Reviewers:
kzar

Visibility:
Public.

More Reviews

Description

Issue 2687 - Don't use Shadow DOM on blogger.com

Patch Set 2 : Wrapped long line #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	include.preload.js	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kzar

Otherwise LGTM https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js#newcode413 include.preload.js:413: if ("createShadowRoot" in document.documentElement && !/\.(?:google|blogger)\.com$/.test(document.domain)) Nit: ...

3 years, 8 months ago (2016-03-19 15:17:00 UTC) #2

Sebastian Noack

3 years, 8 months ago (2016-03-19 15:20:11 UTC) #3

https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js#...
include.preload.js:413: if ("createShadowRoot" in document.documentElement &&
!/\.(?:google|blogger)\.com$/.test(document.domain))
On 2016/03/19 15:16:59, kzar wrote:
> Nit: Mind fixing this long line?

Done.

Expand All Messages | Collapse All Messages