Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(369)

Issue 29338716: Issue 2687 - Don't use Shadow DOM on blogger.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Sebastian Noack
Modified:
3 years, 8 months ago
Reviewers:
kzar
Visibility:
Public.

Description

Issue 2687 - Don't use Shadow DOM on blogger.com

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrapped long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M include.preload.js View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
3 years, 8 months ago (2016-03-19 15:09:21 UTC) #1
kzar
Otherwise LGTM https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js#newcode413 include.preload.js:413: if ("createShadowRoot" in document.documentElement && !/\.(?:google|blogger)\.com$/.test(document.domain)) Nit: ...
3 years, 8 months ago (2016-03-19 15:17:00 UTC) #2
Sebastian Noack
3 years, 8 months ago (2016-03-19 15:20:11 UTC) #3
https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js
File include.preload.js (right):

https://codereview.adblockplus.org/29338716/diff/29338717/include.preload.js#...
include.preload.js:413: if ("createShadowRoot" in document.documentElement &&
!/\.(?:google|blogger)\.com$/.test(document.domain))
On 2016/03/19 15:16:59, kzar wrote:
> Nit: Mind fixing this long line?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5