Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/notificationHelper.js

Issue 29338771: Issue 3843 - Move page load logic to their respective modules (Closed)
Patch Set: Created March 20, 2016, 3:46 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/filterComposer.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/notificationHelper.js
===================================================================
--- a/lib/notificationHelper.js
+++ b/lib/notificationHelper.js
@@ -247,16 +247,6 @@
};
/**
- * Shows the next notification (if any) for the supplied URL.
- *
- * @param {URL} url URL to match notifications to
- */
-exports.showNextNotificationForUrl = function(url)
-{
- NotificationStorage.showNext(stringifyURL(url));
-};
-
-/**
* Gets the active notification to be shown if any.
*
* @return {?object}
@@ -281,4 +271,9 @@
return methods.indexOf(method) > -1;
};
+ext.pages.onLoading.addListener(page =>
+{
+ NotificationStorage.showNext(stringifyURL(page.url));
+});
+
NotificationStorage.addShowListener(showNotification);
« no previous file with comments | « lib/filterComposer.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld