Issue 3853 - Use new messaging API for the first-run page

ext/common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 (function(global)
 {
   if (!global.ext)
     global.ext = {};
 
-  let wrapperSymbol = Symbol("ext-wrapper");

[Thomas Greiner, 2016/04/18 17:47:14]

Detail: I guess the `let` here is unintentional because you said that "let
statements are off limits".

[Wladimir Palant, 2016/04/19 11:57:28]

Correct, that's the problem when testing in newer Firefox versions :-(

+  var wrapperSymbol = Symbol("ext-wrapper");
 
   function wrapFrames(frames)
   {
     if (!frames.length)
       return null;
 
     // We have frames as an array, non-Firefox code expects url and parent
     // properties however.
     Object.defineProperty(frames, "url", {
       enumerable: true,
@@ skipping 19 matching lines @@
       var wrapper = (message, sender) =>
       {
         if (this._windowID && this._windowID != message.targetID)
           return undefined;
 
         return new Promise((resolve, reject) =>
         {
           var sender = {};
           if (message.senderID)
           {
+            // We will only get here on the background side so we can access
+            // the Page object.
             const Page = require("ext_background").Page;
             sender.page = new Page(message.senderID);
           }
           if (message.frames)
             sender.frame = wrapFrames(message.frames);
           if (!listener(message.payload, sender, resolve))
             resolve(undefined);
         });
       };
       listener[wrapperSymbol] = wrapper;
       this._port.on("ext_message", wrapper);
     },
 
     removeListener: function(listener)
     {
       if (listener[wrapperSymbol])
         this._port.off("ext_message", listener[wrapperSymbol]);
     }
   };
 
   if (typeof exports == "object")
     exports = global.ext;
 })(this);