Delta Between Two Patch Sets: new-options.html
Issue 29338983:
issue 3741 - Add "remove" option to list items in new options page (Closed)
Left Patch Set: Impoved accessibility, removed onclick assignments from the collections
Created June 8, 2016, 3:02 p.m.
Right Patch Set: Removed label's "for" attribute, added "aria-lable" to addItem
Created June 24, 2016, 4:35 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-2016 Eyeo GmbH | 4 - Copyright (C) 2006-2016 Eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 76 <div id="dialog-background"></div> | 76 <div id="dialog-background"></div> |
| 77 | 77 |
| 78 <!-- General tab content --> | 78 <!-- General tab content --> |
| 79 <div id="content-general" class="tab-content"> | 79 <div id="content-general" class="tab-content"> |
| 80 <div> | 80 <div> |
| 81 <h1 class="i18n_options_blocking_title"></h1> | 81 <h1 class="i18n_options_blocking_title"></h1> |
| 82 <div class="hbox"> | 82 <div class="hbox"> |
| 83 <div id="blocking-languages"> | 83 <div id="blocking-languages"> |
| 84 <div class="option-name"> | 84 <div class="option-name"> |
| 85 <span class="i18n_options_language_title"></span> | 85 <span class="i18n_options_language_title"></span> |
| 86 <div class="tooltip"> | 86 <span class="i18n_options_readMore" |
| 87 <span class="i18n_options_readMore"></span> | 87 data-tooltip="options_language_title_tooltip" |
| 88 <div role="tooltip"> | 88 data-tooltip-image="skin/tooltips/block.png"></span> |
| 89 <img src="skin/tooltips/block.png" alt="" /> | |
| 90 <p class="i18n_options_language_title_tooltip"></p> | |
| 91 <div class="notes"> | |
| 92 <p class="i18n_options_language_title_tooltip_notes_1">< /p> | |
| 93 <p class="i18n_options_language_title_tooltip_notes_2">< /p> | |
| 94 </div> | |
| 95 </div> | |
| 96 </div> | |
| 97 </div> | 89 </div> |
| 98 <ul id="blocking-languages-table" class="table list"> | 90 <ul id="blocking-languages-table" class="table list"> |
| 99 <template> | 91 <template> |
| 100 <button data-action="toggle-disable-subscription" role="chec kbox" class="control" title="toggle"></button> | 92 <button data-action="toggle-disable-subscription" role="chec kbox" class="control" title="options_control_toggle_title"></button> |
| 101 <label class="display"></label> | 93 <label class="display"></label> |
| 102 <button data-action="remove-subscription" class="delete cont rol" title="remove"></button> | 94 <button data-action="remove-subscription" class="delete cont rol" title="options_control_remove_title"></button> |
| 103 </template> | 95 </template> |
| 104 </ul> | 96 </ul> |
| 105 <div class="controls"> | 97 <div class="controls"> |
| 106 <button data-action="open-dialog" data-dialog="language"> | 98 <button data-action="open-dialog" data-dialog="language"> |
| 107 <span class="icon icon-add"></span> | 99 <span class="icon icon-add"></span> |
| 108 <span class="i18n_options_language_add"></span> | 100 <span class="i18n_options_language_add"></span> |
| 109 </button> | 101 </button> |
| 110 </div> | 102 </div> |
| 111 </div> | 103 </div> |
| 112 <div id="further-blocking"> | 104 <div id="further-blocking"> |
| 113 <div class="option-name"> | 105 <div class="option-name"> |
| 114 <strong class="i18n_options_furtherBlocking_title"></strong> | 106 <strong class="i18n_options_more_title"></strong> |
| 115 <div class="tooltip"> | 107 <span class="i18n_options_readMore" |
| 116 <span class="i18n_options_readMore"></span> | 108 data-tooltip="options_more_title_tooltip" |
| 117 <div role="tooltip" class="flip-vertical"> | 109 data-tooltip-image="skin/tooltips/more.png" |
| 118 <img src="skin/tooltips/more.png" alt="" /> | 110 data-tooltip-flip="horizontal"></span> |
| 119 <p class="i18n_options_furtherBlocking_title_tooltip"></p> | |
| 120 </div> | |
| 121 </div> | |
| 122 </div> | 111 </div> |
| 123 <div id="custom-wrapper"> | 112 <div id="custom-wrapper"> |
| 124 <ul id="recommend-list-table" class="table list"> | 113 <ul id="recommend-list-table" class="table list"> |
| 125 <template> | 114 <template> |
| 126 <button data-action="toggle-remove-subscription" role="che ckbox" class="control"></button> | 115 <button data-action="toggle-remove-subscription" role="che ckbox" class="control"></button> |
| 127 <label class="display"></label> | 116 <div class="fill"> |
| 117 <label class="display" | |
| 118 data-tooltip="options_more_%value%_tooltip" | |
| 119 data-tooltip-native></label> | |
| 120 </div> | |
| 128 </template> | 121 </template> |
| 129 </ul> | 122 </ul> |
| 130 <ul id="custom-list-table" class="table list"> | 123 <ul id="custom-list-table" class="table list"> |
| 131 <template> | 124 <template> |
| 132 <button data-action="toggle-disable-subscription" role="ch eckbox" class="control"></button> | 125 <button data-action="toggle-disable-subscription" role="ch eckbox" class="control" title="options_control_toggle_title"></button> |
| 133 <label class="display"></label> | 126 <label class="display"></label> |
| 134 <button data-action="remove-subscription" class="delete co ntrol"></button> | 127 <button data-action="remove-subscription" class="delete co ntrol" title="options_control_remove_title"></button> |
| 135 </template> | 128 </template> |
| 136 </ul> | 129 </ul> |
| 137 </div> | 130 </div> |
| 138 <div class="controls"> | 131 <div class="controls"> |
| 139 <button data-action="open-dialog" data-dialog="custom"> | 132 <button data-action="open-dialog" data-dialog="custom"> |
| 140 <span class="icon icon-add"></span> | 133 <span class="icon icon-add"></span> |
| 141 <span class="i18n_options_furtherBlocking_add"><span> | 134 <span class="i18n_options_more_add"><span> |
| 142 </button> | 135 </button> |
| 143 </div> | 136 </div> |
| 144 </div> | 137 </div> |
| 145 </div> | 138 </div> |
| 146 </div> | 139 </div> |
| 147 <div> | 140 <div> |
| 148 <h1 class="i18n_options_exceptions_title"></h1> | 141 <h1 class="i18n_options_exceptions_title"></h1> |
| 149 <div class="hbox"> | 142 <div class="hbox"> |
| 150 <div id="acceptable-ads"> | 143 <div id="acceptable-ads"> |
| 151 <div class="option-name"> | 144 <div class="option-name"> |
| 152 <strong class="i18n_options_acceptableAds_title"></strong> | 145 <strong class="i18n_options_acceptableAds_title"></strong> |
| 153 <div class="tooltip"> | 146 <span class="i18n_options_readMore" |
| 154 <span class="i18n_options_readMore"></span> | 147 data-tooltip="options_acceptableAds_title_tooltip" |
| 155 <div role="tooltip"> | 148 data-tooltip-image="skin/tooltips/acceptable-ads.png"></sp an> |
| 156 <img src="skin/tooltips/acceptable-ads.png" alt="" /> | |
| 157 <p class="i18n_options_acceptableAds_title_tooltip_1"></p> | |
| 158 <p class="i18n_options_acceptableAds_title_tooltip_2"></p> | |
| 159 <p class="i18n_options_acceptableAds_title_tooltip_3"></p> | |
| 160 </div> | |
| 161 </div> | |
| 162 </div> | 149 </div> |
| 163 <ul id="acceptableads-table" class="table list"> | 150 <ul id="acceptableads-table" class="table list"> |
| 164 <template> | 151 <template> |
| 165 <button data-action="toggle-remove-subscription" role="check box" class="control"></button> | 152 <button data-action="toggle-remove-subscription" role="check box" class="control"></button> |
| 166 <label class="display"></label> | 153 <label class="display"></label> |
| 167 </template> | 154 </template> |
| 168 </ul> | 155 </ul> |
| 169 </div> | 156 </div> |
| 170 <div id="whitelisting"> | 157 <div id="whitelisting"> |
| 171 <div class="option-name"> | 158 <div class="option-name"> |
| 172 <strong class="i18n_options_whitelisted_title"></strong> | 159 <strong class="i18n_options_whitelisted_title"></strong> |
| 173 <div class="tooltip"> | 160 <span class="i18n_options_readMore" |
| 174 <span class="i18n_options_readMore"></span> | 161 data-tooltip="options_whitelisted_title_tooltip" |
| 175 <div role="tooltip" class="flip-vertical"> | 162 data-tooltip-image="skin/tooltips/whitelisted.png" |
| 176 <img src="skin/tooltips/whitelisted.png" alt="" /> | 163 data-tooltip-flip="horizontal"></span> |
| 177 <p class="i18n_options_whitelisted_title_tooltip_1"></p> | |
| 178 <p class="i18n_options_whitelisted_title_tooltip_2"></p> | |
| 179 <div class="notes"> | |
| 180 <p class="i18n_options_whitelisted_title_tooltip_notes"> </p> | |
| 181 </div> | |
| 182 </div> | |
| 183 </div> | |
| 184 </div> | 164 </div> |
| 185 <ul id="whitelisting-table" class="table list"> | 165 <ul id="whitelisting-table" class="table list"> |
| 186 <template> | 166 <template> |
| 187 <label class="display"></label> | 167 <label class="display"></label> |
| 188 <button data-action="remove-filter" class="delete control">< /button> | 168 <button data-action="remove-filter" class="delete control" t itle="options_control_remove_title"></button> |
| 189 </template> | 169 </template> |
| 190 </ul> | 170 </ul> |
| 191 <div class="controls"> | 171 <div class="controls"> |
| 192 <button data-action="edit-domain-exception"> | 172 <button data-action="edit-domain-exception"> |
| 193 <span class="icon icon-add"></span> | 173 <span class="icon icon-add"></span> |
| 194 <span class="i18n_options_whitelisted_add"></span> | 174 <span class="i18n_options_whitelisted_add"></span> |
| 195 </button> | 175 </button> |
| 196 <div> | 176 <div> |
| 197 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> | 177 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> |
| 198 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" /> | 178 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" /> |
| (...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 240 <span class="i18n_options_tweaks_safariContentBlocker"></span> | 220 <span class="i18n_options_tweaks_safariContentBlocker"></span> |
| 241 </label> | 221 </label> |
| 242 <span id="restart-safari" class="i18n_options_tweaks_restartSafa ri"></span> | 222 <span id="restart-safari" class="i18n_options_tweaks_restartSafa ri"></span> |
| 243 </li> | 223 </li> |
| 244 </ul> | 224 </ul> |
| 245 </div> | 225 </div> |
| 246 | 226 |
| 247 <div> | 227 <div> |
| 248 <h1> | 228 <h1> |
| 249 <span class="i18n_options_filterList_title"></span> | 229 <span class="i18n_options_filterList_title"></span> |
| 250 <div class="tooltip"> | 230 <span class="i18n_options_readMore" |
| 251 <span class="i18n_options_readMore"></span> | 231 data-tooltip="options_filterList_title_tooltip"></span> |
| 252 <div role="tooltip"> | |
| 253 <p class="i18n_options_filterList_title_tooltip"></p> | |
| 254 <div class="notes"> | |
| 255 <p class="i18n_options_filterList_title_tooltip_notes_1"></p > | |
| 256 <p class="i18n_options_filterList_title_tooltip_notes_2"></p > | |
| 257 </div> | |
| 258 </div> | |
| 259 </div> | |
| 260 </h1> | 232 </h1> |
| 261 <ul class="tabs horizontal"> | 233 <ul class="tabs horizontal"> |
| 262 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li> | 234 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li> |
| 263 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li> | 235 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li> |
| 264 </ul> | 236 </ul> |
| 265 <div id="filter-lists"> | 237 <div id="filter-lists"> |
| 266 <div id="all-filter-lists"> | 238 <div id="all-filter-lists"> |
| 267 <div class="table-header"> | 239 <div class="table-header"> |
| 268 <h2 class="i18n_options_column_name"></h2> | 240 <h2 class="i18n_options_column_name"></h2> |
| 269 <h2 class="i18n_options_column_date"></h2> | 241 <h2 class="i18n_options_column_date"></h2> |
| (...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 305 </button> | 277 </button> |
| 306 <button data-action="update-all-subscriptions"> | 278 <button data-action="update-all-subscriptions"> |
| 307 <span class="icon icon-update"></span> | 279 <span class="icon icon-update"></span> |
| 308 <span class="i18n_options_filterList_update"></span> | 280 <span class="i18n_options_filterList_update"></span> |
| 309 </button> | 281 </button> |
| 310 </div> | 282 </div> |
| 311 </div> | 283 </div> |
| 312 <div id="custom-filters"> | 284 <div id="custom-filters"> |
| 313 <h2 id="custom-filters-header"> | 285 <h2 id="custom-filters-header"> |
| 314 <span class="i18n_options_customFilters_title"></span> | 286 <span class="i18n_options_customFilters_title"></span> |
| 315 <div class="tooltip"> | 287 <span class="i18n_options_readMore" |
| 316 <span class="i18n_options_readMore"></span> | 288 data-tooltip="options_customFilters_title_tooltip"></span> |
| 317 <div role="tooltip"> | |
| 318 <p class="i18n_options_customFilters_title_tooltip"></p> | |
| 319 </div> | |
| 320 </div> | |
| 321 </h2> | 289 </h2> |
| 322 <div id="custom-filters-wrapper"> | 290 <div id="custom-filters-wrapper"> |
| 323 <div id="custom-filters-list-wrapper"> | 291 <div id="custom-filters-list-wrapper"> |
| 324 <ul id="custom-filters-table" class="table list"> | 292 <ul id="custom-filters-table" class="table list"> |
| 325 <template> | 293 <template> |
| 326 <label class="display"></label> | 294 <label class="display"></label> |
| 327 </template> | 295 </template> |
| 328 </ul> | 296 </ul> |
| 329 <form id="custom-filters-add" class="controls"> | 297 <form id="custom-filters-add" class="controls"> |
| 330 <input type="text"/> | 298 <input type="text"/> |
| (...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 434 <div class="url"></div> | 402 <div class="url"></div> |
| 435 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> | 403 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> |
| 436 </div> | 404 </div> |
| 437 </div> | 405 </div> |
| 438 </div> | 406 </div> |
| 439 <!-- Placeholder element to determine when to wrap focus around --> | 407 <!-- Placeholder element to determine when to wrap focus around --> |
| 440 <span class="focus-last" tabindex="0"></span> | 408 <span class="focus-last" tabindex="0"></span> |
| 441 </div> | 409 </div> |
| 442 </body> | 410 </body> |
| 443 </html> | 411 </html> |
| LEFT | RIGHT |
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
