Delta Between Two Patch Sets: new-options.html
Issue 29338983:
issue 3741 - Add "remove" option to list items in new options page (Closed)
Left Patch Set: Rebaseed to changeset 84
Created June 10, 2016, 4:36 p.m.
Right Patch Set: Removed label's "for" attribute, added "aria-lable" to addItem
Created June 24, 2016, 4:35 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-2016 Eyeo GmbH | 4 - Copyright (C) 2006-2016 Eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 82 <div class="hbox"> | 82 <div class="hbox"> |
| 83 <div id="blocking-languages"> | 83 <div id="blocking-languages"> |
| 84 <div class="option-name"> | 84 <div class="option-name"> |
| 85 <span class="i18n_options_language_title"></span> | 85 <span class="i18n_options_language_title"></span> |
| 86 <span class="i18n_options_readMore" | 86 <span class="i18n_options_readMore" |
| 87 data-tooltip="options_language_title_tooltip" | 87 data-tooltip="options_language_title_tooltip" |
| 88 data-tooltip-image="skin/tooltips/block.png"></span> | 88 data-tooltip-image="skin/tooltips/block.png"></span> |
| 89 </div> | 89 </div> |
| 90 <ul id="blocking-languages-table" class="table list"> | 90 <ul id="blocking-languages-table" class="table list"> |
| 91 <template> | 91 <template> |
| 92 <button data-action="toggle-disable-subscription" role="chec kbox" class="control" title="toggle"></button> | 92 <button data-action="toggle-disable-subscription" role="chec kbox" class="control" title="options_control_toggle_title"></button> |
|
Thomas Greiner
2016/06/16 10:42:22
The titles need to be translatable as well.
saroyanm
2016/06/16 18:22:59
Done.
| |
| 93 <label class="display"></label> | 93 <label class="display"></label> |
| 94 <button data-action="remove-subscription" class="delete cont rol" title="remove"></button> | 94 <button data-action="remove-subscription" class="delete cont rol" title="options_control_remove_title"></button> |
| 95 </template> | 95 </template> |
| 96 </ul> | 96 </ul> |
| 97 <div class="controls"> | 97 <div class="controls"> |
| 98 <button data-action="open-dialog" data-dialog="language"> | 98 <button data-action="open-dialog" data-dialog="language"> |
| 99 <span class="icon icon-add"></span> | 99 <span class="icon icon-add"></span> |
| 100 <span class="i18n_options_language_add"></span> | 100 <span class="i18n_options_language_add"></span> |
| 101 </button> | 101 </button> |
| 102 </div> | 102 </div> |
| 103 </div> | 103 </div> |
| 104 <div id="further-blocking"> | 104 <div id="further-blocking"> |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 115 <button data-action="toggle-remove-subscription" role="che ckbox" class="control"></button> | 115 <button data-action="toggle-remove-subscription" role="che ckbox" class="control"></button> |
| 116 <div class="fill"> | 116 <div class="fill"> |
| 117 <label class="display" | 117 <label class="display" |
| 118 data-tooltip="options_more_%value%_tooltip" | 118 data-tooltip="options_more_%value%_tooltip" |
| 119 data-tooltip-native></label> | 119 data-tooltip-native></label> |
| 120 </div> | 120 </div> |
| 121 </template> | 121 </template> |
| 122 </ul> | 122 </ul> |
| 123 <ul id="custom-list-table" class="table list"> | 123 <ul id="custom-list-table" class="table list"> |
| 124 <template> | 124 <template> |
| 125 <button data-action="toggle-disable-subscription" role="ch eckbox" class="control" title="toggle"></button> | 125 <button data-action="toggle-disable-subscription" role="ch eckbox" class="control" title="options_control_toggle_title"></button> |
| 126 <label class="display"></label> | 126 <label class="display"></label> |
| 127 <button data-action="remove-subscription" class="delete co ntrol" title="remove"></button> | 127 <button data-action="remove-subscription" class="delete co ntrol" title="options_control_remove_title"></button> |
| 128 </template> | 128 </template> |
| 129 </ul> | 129 </ul> |
| 130 </div> | 130 </div> |
| 131 <div class="controls"> | 131 <div class="controls"> |
| 132 <button data-action="open-dialog" data-dialog="custom"> | 132 <button data-action="open-dialog" data-dialog="custom"> |
| 133 <span class="icon icon-add"></span> | 133 <span class="icon icon-add"></span> |
| 134 <span class="i18n_options_more_add"><span> | 134 <span class="i18n_options_more_add"><span> |
| 135 </button> | 135 </button> |
| 136 </div> | 136 </div> |
| 137 </div> | 137 </div> |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 158 <div class="option-name"> | 158 <div class="option-name"> |
| 159 <strong class="i18n_options_whitelisted_title"></strong> | 159 <strong class="i18n_options_whitelisted_title"></strong> |
| 160 <span class="i18n_options_readMore" | 160 <span class="i18n_options_readMore" |
| 161 data-tooltip="options_whitelisted_title_tooltip" | 161 data-tooltip="options_whitelisted_title_tooltip" |
| 162 data-tooltip-image="skin/tooltips/whitelisted.png" | 162 data-tooltip-image="skin/tooltips/whitelisted.png" |
| 163 data-tooltip-flip="horizontal"></span> | 163 data-tooltip-flip="horizontal"></span> |
| 164 </div> | 164 </div> |
| 165 <ul id="whitelisting-table" class="table list"> | 165 <ul id="whitelisting-table" class="table list"> |
| 166 <template> | 166 <template> |
| 167 <label class="display"></label> | 167 <label class="display"></label> |
| 168 <button data-action="remove-filter" class="delete control" t itle="remove"></button> | 168 <button data-action="remove-filter" class="delete control" t itle="options_control_remove_title"></button> |
| 169 </template> | 169 </template> |
| 170 </ul> | 170 </ul> |
| 171 <div class="controls"> | 171 <div class="controls"> |
| 172 <button data-action="edit-domain-exception"> | 172 <button data-action="edit-domain-exception"> |
| 173 <span class="icon icon-add"></span> | 173 <span class="icon icon-add"></span> |
| 174 <span class="i18n_options_whitelisted_add"></span> | 174 <span class="i18n_options_whitelisted_add"></span> |
| 175 </button> | 175 </button> |
| 176 <div> | 176 <div> |
| 177 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> | 177 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> |
| 178 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" /> | 178 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" /> |
| (...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 402 <div class="url"></div> | 402 <div class="url"></div> |
| 403 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> | 403 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> |
| 404 </div> | 404 </div> |
| 405 </div> | 405 </div> |
| 406 </div> | 406 </div> |
| 407 <!-- Placeholder element to determine when to wrap focus around --> | 407 <!-- Placeholder element to determine when to wrap focus around --> |
| 408 <span class="focus-last" tabindex="0"></span> | 408 <span class="focus-last" tabindex="0"></span> |
| 409 </div> | 409 </div> |
| 410 </body> | 410 </body> |
| 411 </html> | 411 </html> |
| LEFT | RIGHT |
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
