Unified Diff: new-options.html
Issue 29338983:
issue 3741 - Add "remove" option to list items in new options page (Closed)
Patch Set: Impoved accessibility, removed onclick assignments from the collections
Created June 8, 2016, 3:02 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: new-options.html |
| =================================================================== |
| --- a/new-options.html |
| +++ b/new-options.html |
| @@ -97,8 +97,9 @@ |
| </div> |
| <ul id="blocking-languages-table" class="table list"> |
| <template> |
| - <button role="checkbox" class="control"></button> |
| + <button data-action="toggle-disable-subscription" role="checkbox" class="control" title="toggle"></button> |
| <label class="display"></label> |
| + <button data-action="remove-subscription" class="delete control" title="remove"></button> |
| </template> |
| </ul> |
| <div class="controls"> |
| @@ -122,15 +123,15 @@ |
| <div id="custom-wrapper"> |
| <ul id="recommend-list-table" class="table list"> |
| <template> |
| - <button role="checkbox" class="control"></button> |
| + <button data-action="toggle-remove-subscription" role="checkbox" class="control"></button> |
| <label class="display"></label> |
| - <span class="i18n_options_popular popular"></span> |
| </template> |
| </ul> |
| <ul id="custom-list-table" class="table list"> |
| <template> |
| - <button role="checkbox" class="control"></button> |
| + <button data-action="toggle-disable-subscription" role="checkbox" class="control"></button> |
| <label class="display"></label> |
| + <button data-action="remove-subscription" class="delete control"></button> |
| </template> |
| </ul> |
| </div> |
| @@ -161,7 +162,7 @@ |
| </div> |
| <ul id="acceptableads-table" class="table list"> |
| <template> |
| - <button role="checkbox" class="control"></button> |
| + <button data-action="toggle-remove-subscription" role="checkbox" class="control"></button> |
| <label class="display"></label> |
| </template> |
| </ul> |
| @@ -183,8 +184,8 @@ |
| </div> |
| <ul id="whitelisting-table" class="table list"> |
| <template> |
| - <button class="delete control"></button> |
| <label class="display"></label> |
| + <button data-action="remove-filter" class="delete control"></button> |
| </template> |
| </ul> |
| <div class="controls"> |
| @@ -269,7 +270,7 @@ |
| </div> |
| <ul class="table cols" id="all-filter-lists-table"> |
| <template> |
| - <button role="checkbox" class="control"></button> |
| + <button data-action="toggle-disable-subscription" role="checkbox" class="control"></button> |
| <div> |
| <label data-action="open-context-menu" class="display"></label> |
| <div data-action="open-context-menu" class="arrow"> |
| @@ -404,7 +405,7 @@ |
| </div> |
| <ul id="all-lang-table" class="table list"> |
| <template> |
| - <button class="button-add control"> |
| + <button data-action="add-language-subscription" class="button-add control"> |
| +<span class="i18n_options_button_add"></span> |
| </button> |
| <label class="display"></label> |
« no previous file with comments
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
