Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(393)

Issue 29339020: Issue 3868 - Use the new FilterNotifier API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Sebastian Noack
Modified:
3 years, 8 months ago
Reviewers:
kzar
Visibility:
Public.

Description

Issue 3868 - Use the new FilterNotifier API

Patch Set 1 #

Patch Set 2 : Updated depdendencies and use EventEmitter.listeners() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -281 lines) Patch
M dependencies View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/devtools.js View 4 chunks +23 lines, -30 lines 0 comments Download
R lib/events.js View 1 chunk +0 lines, -84 lines 0 comments Download
M lib/filterComposer.js View 1 chunk +1 line, -5 lines 0 comments Download
M lib/icon.js View 1 chunk +4 lines, -7 lines 0 comments Download
M lib/messaging.js View 1 1 chunk +17 lines, -20 lines 0 comments Download
M lib/requestBlocker.js View 3 chunks +28 lines, -40 lines 0 comments Download
M lib/stats.js View 2 chunks +3 lines, -6 lines 0 comments Download
M lib/subscriptionInit.js View 2 chunks +4 lines, -16 lines 0 comments Download
M lib/whitelisting.js View 1 chunk +7 lines, -8 lines 0 comments Download
M metadata.common View 1 chunk +1 line, -1 line 0 comments Download
M options.js View 3 chunks +71 lines, -54 lines 0 comments Download
M stats.js View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
3 years, 8 months ago (2016-03-23 20:16:25 UTC) #1
kzar
As discussed in IRC, if we made the filter notifier pass the name of the ...
3 years, 8 months ago (2016-03-24 11:23:08 UTC) #2
Sebastian Noack
On 2016/03/24 11:23:08, kzar wrote: > As discussed in IRC, if we made the filter ...
3 years, 8 months ago (2016-03-24 11:58:37 UTC) #3
Sebastian Noack
I've updated the dependencies, and adapted Port to use the new listeners() method rather than ...
3 years, 8 months ago (2016-03-24 15:30:21 UTC) #4
kzar
3 years, 8 months ago (2016-03-24 15:38:25 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5