stats.js - Issue 29339020: Issue 3868 - Use the new FilterNotifier API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: stats.js

Issue 29339020: Issue 3868 - Use the new FilterNotifier API (Closed)

Patch Set: Created March 23, 2016, 8:15 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: stats.js

===================================================================

--- a/stats.js

+++ b/stats.js

@@ -81,7 +81,7 @@

currentPage = pages[0];

updateStats();

- FilterNotifier.addListener(onNotify);

+ FilterNotifier.on("filter.hitCount", updateStats);

document.getElementById("stats-container").removeAttribute("hidden");

});

@@ -89,13 +89,7 @@

function onUnload()

{

- FilterNotifier.removeListener(onNotify);

- }

- function onNotify(action, item)

- {

- if (action == "filter.hitCount")

- updateStats();

+ FilterNotifier.off("filter.hitCount", updateStats);

}

function updateStats()

« no previous file with comments | « options.js ('k') | no next file » | no next file with comments »