Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339034: Issue 3869 - Use the new FilterNotifier API (Closed)

Created:
March 23, 2016, 11 p.m. by Sebastian Noack
Modified:
March 24, 2016, 3:22 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3869 - Use the new FilterNotifier API

Patch Set 1 #

Total comments: 8

Patch Set 2 : Unsupport *.listen with null #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -105 lines) Patch
M background.js View 9 chunks +17 lines, -30 lines 0 comments Download
M messageResponder.js View 1 9 chunks +57 lines, -75 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js File messageResponder.js (left): https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js#oldcode287 messageResponder.js:287: else I wonder whether we should prehaps unsupport calling ...
March 23, 2016, 11:15 p.m. (2016-03-23 23:15:51 UTC) #1
Thomas Greiner
LGTM https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js File messageResponder.js (left): https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js#oldcode388 messageResponder.js:388: FilterNotifier.triggerListeners("subscription.disabled", On 2016/03/23 23:15:51, Sebastian Noack wrote: > ...
March 24, 2016, 2:12 p.m. (2016-03-24 14:12:17 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js File messageResponder.js (left): https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js#oldcode287 messageResponder.js:287: else On 2016/03/23 23:15:51, Sebastian Noack wrote: > I ...
March 24, 2016, 2:22 p.m. (2016-03-24 14:22:35 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js File messageResponder.js (left): https://codereview.adblockplus.org/29339034/diff/29339035/messageResponder.js#oldcode287 messageResponder.js:287: else On 2016/03/24 14:22:35, Thomas Greiner wrote: > On ...
March 24, 2016, 2:40 p.m. (2016-03-24 14:40:35 UTC) #4
Thomas Greiner
March 24, 2016, 3:15 p.m. (2016-03-24 15:15:05 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld