Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339038: Issue 3862 - Added EventEmitter.listeners() (Closed)

Created:
March 24, 2016, 11:03 a.m. by Sebastian Noack
Modified:
April 4, 2016, 1:01 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 3862 - Added EventEmitter.listeners()

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added missing documentation for argument #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M lib/events.js View 1 2 chunks +18 lines, -10 lines 3 comments Download

Messages

Total messages: 5
Sebastian Noack
https://codereview.adblockplus.org/29339038/diff/29339039/lib/events.js File lib/events.js (right): https://codereview.adblockplus.org/29339038/diff/29339039/lib/events.js#newcode87 lib/events.js:87: listeners: function(name) node.js has that method as well. We ...
March 24, 2016, 11:07 a.m. (2016-03-24 11:07:13 UTC) #1
kzar
https://codereview.adblockplus.org/29339038/diff/29339043/lib/events.js File lib/events.js (right): https://codereview.adblockplus.org/29339038/diff/29339043/lib/events.js#newcode102 lib/events.js:102: let args = []; Any reason why you now ...
March 24, 2016, 11:29 a.m. (2016-03-24 11:29:53 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29339038/diff/29339043/lib/events.js File lib/events.js (right): https://codereview.adblockplus.org/29339038/diff/29339043/lib/events.js#newcode102 lib/events.js:102: let args = []; On 2016/03/24 11:29:53, kzar wrote: ...
March 24, 2016, 11:33 a.m. (2016-03-24 11:33:27 UTC) #3
kzar
LGTM https://codereview.adblockplus.org/29339038/diff/29339043/lib/events.js File lib/events.js (right): https://codereview.adblockplus.org/29339038/diff/29339043/lib/events.js#newcode102 lib/events.js:102: let args = []; On 2016/03/24 11:33:27, Sebastian ...
March 24, 2016, 11:35 a.m. (2016-03-24 11:35:59 UTC) #4
Wladimir Palant
April 4, 2016, 1:01 p.m. (2016-04-04 13:01:27 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld