Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339076: Noissue - Avoid try/catch triggering a deoptimization in message listener (Closed)

Created:
March 24, 2016, 6:19 p.m. by Sebastian Noack
Modified:
March 29, 2016, 12:37 p.m.
Reviewers:
kzar
CC:
Thomas Greiner
Visibility:
Public.

Description

Noissue - Avoid try/catch triggering a deoptimization in message listener

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M messageResponder.js View 2 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
V8 causes the whole function to run in interpreted mode (instead being JIT-compiled) if you ...
March 24, 2016, 6:26 p.m. (2016-03-24 18:26:11 UTC) #1
Sebastian Noack
Thomas is busy, Dave would you mind reviewing this?
March 29, 2016, 11:45 a.m. (2016-03-29 11:45:24 UTC) #2
kzar
March 29, 2016, 12:30 p.m. (2016-03-29 12:30:37 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld