Noissue - Use hash tables instead arrays to keep track of registered listeners

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 51 matching lines @@
     for (var i = 0; i < keys.length; i++)
       result[keys[i]] = obj[keys[i]];
     return result;
   }
 
   var convertSubscription = convertObject.bind(null, ["disabled",
     "downloadStatus", "homepage", "lastDownload", "title", "url"]);
   var convertFilter = convertObject.bind(null, ["text"]);
 
   var changeListeners = new global.ext.PageMap();
-  var listenedPreferences = [];
-  var listenedFilterChanges = [];
+  var listenedPreferences = Object.create(null);
+  var listenedFilterChanges = Object.create(null);
   var messageTypes = {
     "app": "app.listen",
     "filter": "filters.listen",
     "pref": "prefs.listen",
     "subscription": "subscriptions.listen"
   };
 
   function sendMessage(type, action)
   {
     var pages = changeListeners.keys();
@@ skipping 31 matching lines @@
   function addFilterListeners(type, actions)
   {
     actions.forEach(function(action)
     {
       var name;
       if (type == "filter" && action == "loaded")
         name = "load";
       else
         name = type + "." + action;
 
-      if (listenedFilterChanges.indexOf(name) == -1)
+      if (!(name in listenedFilterChanges))
       {
-        listenedFilterChanges.push(name);
+        listenedFilterChanges[name] = null;
         FilterNotifier.on(name, function()
         {
           var args = [type, action];
           for (var i = 0; i < arguments.length; i++)
             args.push(arguments[i]);
           sendMessage.apply(null, args);
         });
       }
     });
   }
@@ skipping 165 matching lines @@
         else
           FilterStorage.removeFilter(filter, subscription, message.index);
         break;
       case "prefs.get":
         callback(Prefs[message.key]);
         break;
       case "prefs.listen":
         getListenerFilters(sender.page).pref = message.filter;
         message.filter.forEach(function(preference)
         {
-          if (listenedPreferences.indexOf(preference) == -1)
+          if (!(preference in listenedPreferences))
           {
-            listenedPreferences.push(preference);
+            listenedPreferences[preference] = null;
             Prefs.on(preference, function()
             {
               sendMessage("pref", preference, Prefs[preference]);
             });
           }
         });
         break;
       case "prefs.toggle":
         if (message.key == "notifications_ignoredcategories")
           NotificationStorage.toggleIgnoreCategory("*");
@@ skipping 73 matching lines @@
           if (subscription instanceof DownloadableSubscription)
             Synchronizer.execute(subscription, true);
         }
         break;
       case "subscriptions.isDownloading":
         callback(Synchronizer.isExecuting(message.url));
         break;
     }
   });
 })(this);