Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339099: Noissue - Rename message type when propagating events to the content script (Closed)

Created:
March 29, 2016, 10:59 a.m. by Sebastian Noack
Modified:
March 29, 2016, 12:37 p.m.
Reviewers:
Thomas Greiner
CC:
kzar
Visibility:
Public.

Description

Noissue - Rename message type when propagating events to the content script

Patch Set 1 #

Patch Set 2 : Rename *.event to *.respond #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M firstRun.js View 1 1 chunk +1 line, -1 line 0 comments Download
M messageResponder.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
M options.js View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
As discussed on IRC, messages send via chrome.runtime.sendMessage are not only dispatched to the background ...
March 29, 2016, 11:03 a.m. (2016-03-29 11:03:11 UTC) #1
Thomas Greiner
The overall changes look good but let's stick to the "<noun>.<verb>" message naming convention (e.g. ...
March 29, 2016, 11:09 a.m. (2016-03-29 11:09:10 UTC) #2
Sebastian Noack
On 2016/03/29 11:09:10, Thomas Greiner wrote: > The overall changes look good but let's stick ...
March 29, 2016, 11:11 a.m. (2016-03-29 11:11:54 UTC) #3
Thomas Greiner
March 29, 2016, 11:13 a.m. (2016-03-29 11:13:23 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld