Unified Diff: safari/ext/background.js
Issue 29339112:
Issue 3716 - Split up files stored in storage.local (Closed)
Patch Set: Make sure we don't leak chunks. Edit comments. Simplify safari storage.
Created March 31, 2016, 6:33 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/prefs.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: safari/ext/background.js |
| =================================================================== |
| --- a/safari/ext/background.js |
| +++ b/safari/ext/background.js |
| @@ -705,10 +705,12 @@ |
| setTimeout(callback, 0, items); |
| }, |
| - set: function(key, value, callback) |
| + set: function(items, callback) |
| { |
| - safari.extension.settings[key] = value; |
| - |
| + for (let key in items) |
| + { |
|
Sebastian Noack
2016/03/31 19:30:25
Nit: the braces here are unnecessary.
|
| + safari.extension.settings[key] = items[key]; |
| + } |
| if (callback) |
| setTimeout(callback, 0); |
|
Sebastian Noack
2016/03/31 19:30:25
Nit: While changing the code here anyway, note tha
|
| }, |
« no previous file with comments
|
« lib/prefs.js ('k')
|
no next file »
|
no next file with comments »
