options.js - Issue 29339116: Issue 3877 - Fixed filter change listener regression in options page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: options.js

Issue 29339116: Issue 3877 - Fixed filter change listener regression in options page (Closed)

Patch Set: Created March 30, 2016, 12:09 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: options.js

diff --git a/options.js b/options.js

index 8ab05ccc705aae3da95b2ca51dc01f9c90e61f26..daf7b8c7b34e60cf165146df1500339e77e37a9b 100644

--- a/options.js

+++ b/options.js

@@ -452,7 +452,7 @@ function onSubscriptionAdded(subscription)

if (subscription instanceof SpecialSubscription)

{

for (var i = 0; i < subscription.filters.length; i++)

- onFilterChange("filter.added", subscription.filters[i]);

+ onFilterAdded(subscription.filters[i]);

}

else if (subscription.url == Prefs.subscriptions_exceptionsurl)

$("#acceptableAds").prop("checked", true);

@@ -465,7 +465,7 @@ function onSubscriptionRemoved(subscription)

if (subscription instanceof SpecialSubscription)

{

for (var i = 0; i < subscription.filters.length; i++)

- onFilterChange("filter.removed", subscription.filters[i]);

+ onFilterRemoved(subscription.filters[i]);

}

else if (subscription.url == Prefs.subscriptions_exceptionsurl)

$("#acceptableAds").prop("checked", false);

« no previous file with comments | « no previous file | no next file » | no next file with comments »