Issue 3846 - Add notification for users using an old SBrowser version

src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 60 matching lines @@
     super.onStart();
     EngineService.startService(this, this);
   }
 
   @Override
   protected void onStop()
   {
     super.onStop();
   }
 
-  private void checkForCompatibleSBrowser()
+  private void checkForCompatibleSBrowserAndProceed()
   {
     if (!Engine.hasCompatibleSBrowserInstalled(this.getApplicationContext()))
     {
       final AlertDialog d = new AlertDialog.Builder(this)
           .setCancelable(false)
           .setTitle(R.string.sbrowser_dialog_title)
           .setMessage(Html.fromHtml(this.readTextFile(R.raw.sbrowser_dialog)))
           .setNeutralButton(R.string.sbrowser_dialog_button, new OnClickListener()
           {
             @Override
             public void onClick(DialogInterface dialog, int which)
             {
               try
               {
                 startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse("market://details?id="
                     + SBROWSER_APP_ID)));
               }
               catch (final Throwable t)
               {
                 startActivity(new Intent(Intent.ACTION_VIEW, Uri
                     .parse("https://play.google.com/store/apps/details?id=" + SBROWSER_APP_ID)));
               }
             }
           }).create();
       d.show();
     }
     else
     {
-      this.checkAAStatus();
-    }
-  }
-
-  private void checkAAStatus()
+      this.checkAAStatusAndProceed();
+    }
+  }
+
+  private void checkAAStatusAndProceed()
   {
     final SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(this);
     final String keyAaInfoShown = this.getString(R.string.key_aa_info_shown);
     final boolean aaInfoShown = prefs.getBoolean(keyAaInfoShown, false);
     if (!aaInfoShown)
     {
       final AlertDialog d = new AlertDialog.Builder(this)
           .setCancelable(false)
           .setTitle(R.string.aa_dialog_title)
           .setMessage(Html.fromHtml(this.readTextFile(R.raw.aa_dialog)))
@@ skipping 44 matching lines @@
   @Override
   public void onEngineCreated(Engine engine, boolean success)
   {
     Log.d(TAG, "onEngineCreated: " + success);
     this.engine = success ? engine : null;
     if (this.progressDialog != null)
     {
       this.progressDialog.dismiss();
       this.progressDialog = null;
 
-      this.checkForCompatibleSBrowser();
+      this.checkForCompatibleSBrowserAndProceed();
     }
   }
 
   @Override
   public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key)
   {
     if (this.getString(R.string.key_automatic_updates).equals(key) && this.engine != null)
     {
       this.engine.connectivityChanged();
     }
@@ skipping 35 matching lines @@
         r.close();
       }
     }
     catch (IOException e)
     {
       Log.e(TAG, "Resource reading failed for: " + id, e);
       return "...";
     }
   }
 }