Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339231: Issue 3882 - Make checkbox labels sensitive on the option page (Closed)

Created:
March 31, 2016, 4:39 p.m. by Sebastian Noack
Modified:
April 1, 2016, 5:30 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3882 - Make checkbox labels sensitive on the option page

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use <label> more consistently #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M options.html View 1 9 chunks +25 lines, -17 lines 0 comments Download
M options.js View 1 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 31, 2016, 4:40 p.m. (2016-03-31 16:40:23 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29339231/diff/29339232/options.js File options.js (right): https://codereview.adblockplus.org/29339231/diff/29339232/options.js#newcode96 options.js:96: control.setAttribute("aria-labelledby", labelId); Since we no longer need to prevent ...
March 31, 2016, 4:54 p.m. (2016-03-31 16:54:37 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29339231/diff/29339232/options.js File options.js (right): https://codereview.adblockplus.org/29339231/diff/29339232/options.js#newcode96 options.js:96: control.setAttribute("aria-labelledby", labelId); On 2016/03/31 16:54:37, Thomas Greiner wrote: > ...
March 31, 2016, 5:18 p.m. (2016-03-31 17:18:13 UTC) #3
Thomas Greiner
April 1, 2016, 4:35 p.m. (2016-04-01 16:35:55 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld