Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: options.html

Issue 29339231: Issue 3882 - Make checkbox labels sensitive on the option page (Closed)
Patch Set: Use <label> more consistently Created April 1, 2016, 1:33 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | options.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2016 Eyeo GmbH 4 - Copyright (C) 2006-2016 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 <div class="notes"> 91 <div class="notes">
92 <p class="i18n_options_language_title_tooltip_notes_1">< /p> 92 <p class="i18n_options_language_title_tooltip_notes_1">< /p>
93 <p class="i18n_options_language_title_tooltip_notes_2">< /p> 93 <p class="i18n_options_language_title_tooltip_notes_2">< /p>
94 </div> 94 </div>
95 </div> 95 </div>
96 </div> 96 </div>
97 </div> 97 </div>
98 <ul id="blocking-languages-table" class="table list"> 98 <ul id="blocking-languages-table" class="table list">
99 <template> 99 <template>
100 <button role="checkbox" class="control"></button> 100 <button role="checkbox" class="control"></button>
101 <span class="display"></span> 101 <label class="display"></label>
102 </template> 102 </template>
103 </ul> 103 </ul>
104 <div class="controls"> 104 <div class="controls">
105 <button data-action="open-dialog" data-dialog="language"> 105 <button data-action="open-dialog" data-dialog="language">
106 <span class="icon icon-add"></span> 106 <span class="icon icon-add"></span>
107 <span class="i18n_options_language_add"></span> 107 <span class="i18n_options_language_add"></span>
108 </button> 108 </button>
109 </div> 109 </div>
110 </div> 110 </div>
111 <div id="further-blocking"> 111 <div id="further-blocking">
112 <div class="option-name"> 112 <div class="option-name">
113 <strong class="i18n_options_furtherBlocking_title"></strong> 113 <strong class="i18n_options_furtherBlocking_title"></strong>
114 <div class="tooltip"> 114 <div class="tooltip">
115 <span class="i18n_options_readMore"></span> 115 <span class="i18n_options_readMore"></span>
116 <div role="tooltip" class="flip-vertical"> 116 <div role="tooltip" class="flip-vertical">
117 <img src="skin/tooltips/more.png" alt="" /> 117 <img src="skin/tooltips/more.png" alt="" />
118 <p class="i18n_options_furtherBlocking_title_tooltip"></p> 118 <p class="i18n_options_furtherBlocking_title_tooltip"></p>
119 </div> 119 </div>
120 </div> 120 </div>
121 </div> 121 </div>
122 <div id="custom-wrapper"> 122 <div id="custom-wrapper">
123 <ul id="recommend-list-table" class="table list"> 123 <ul id="recommend-list-table" class="table list">
124 <template> 124 <template>
125 <button role="checkbox" class="control"></button> 125 <button role="checkbox" class="control"></button>
126 <span class="display"></span> 126 <label class="display"></label>
127 <span class="i18n_options_popular popular"></span> 127 <span class="i18n_options_popular popular"></span>
128 </template> 128 </template>
129 </ul> 129 </ul>
130 <ul id="custom-list-table" class="table list"> 130 <ul id="custom-list-table" class="table list">
131 <template> 131 <template>
132 <button role="checkbox" class="control"></button> 132 <button role="checkbox" class="control"></button>
133 <span class="display"></span> 133 <label class="display"></label>
134 </template> 134 </template>
135 </ul> 135 </ul>
136 </div> 136 </div>
137 <div class="controls"> 137 <div class="controls">
138 <button data-action="open-dialog" data-dialog="custom"> 138 <button data-action="open-dialog" data-dialog="custom">
139 <span class="icon icon-add"></span> 139 <span class="icon icon-add"></span>
140 <span class="i18n_options_furtherBlocking_add"><span> 140 <span class="i18n_options_furtherBlocking_add"><span>
141 </button> 141 </button>
142 </div> 142 </div>
143 </div> 143 </div>
(...skipping 11 matching lines...) Expand all
155 <img src="skin/tooltips/acceptable-ads.png" alt="" /> 155 <img src="skin/tooltips/acceptable-ads.png" alt="" />
156 <p class="i18n_options_acceptableAds_title_tooltip_1"></p> 156 <p class="i18n_options_acceptableAds_title_tooltip_1"></p>
157 <p class="i18n_options_acceptableAds_title_tooltip_2"></p> 157 <p class="i18n_options_acceptableAds_title_tooltip_2"></p>
158 <p class="i18n_options_acceptableAds_title_tooltip_3"></p> 158 <p class="i18n_options_acceptableAds_title_tooltip_3"></p>
159 </div> 159 </div>
160 </div> 160 </div>
161 </div> 161 </div>
162 <ul id="acceptableads-table" class="table list"> 162 <ul id="acceptableads-table" class="table list">
163 <template> 163 <template>
164 <button role="checkbox" class="control"></button> 164 <button role="checkbox" class="control"></button>
165 <span class="display"></span> 165 <label class="display"></label>
166 </template> 166 </template>
167 </ul> 167 </ul>
168 </div> 168 </div>
169 <div id="whitelisting"> 169 <div id="whitelisting">
170 <div class="option-name"> 170 <div class="option-name">
171 <strong class="i18n_options_whitelisted_title"></strong> 171 <strong class="i18n_options_whitelisted_title"></strong>
172 <div class="tooltip"> 172 <div class="tooltip">
173 <span class="i18n_options_readMore"></span> 173 <span class="i18n_options_readMore"></span>
174 <div role="tooltip" class="flip-vertical"> 174 <div role="tooltip" class="flip-vertical">
175 <img src="skin/tooltips/whitelisted.png" alt="" /> 175 <img src="skin/tooltips/whitelisted.png" alt="" />
176 <p class="i18n_options_whitelisted_title_tooltip_1"></p> 176 <p class="i18n_options_whitelisted_title_tooltip_1"></p>
177 <p class="i18n_options_whitelisted_title_tooltip_2"></p> 177 <p class="i18n_options_whitelisted_title_tooltip_2"></p>
178 <div class="notes"> 178 <div class="notes">
179 <p class="i18n_options_whitelisted_title_tooltip_notes"> </p> 179 <p class="i18n_options_whitelisted_title_tooltip_notes"> </p>
180 </div> 180 </div>
181 </div> 181 </div>
182 </div> 182 </div>
183 </div> 183 </div>
184 <ul id="whitelisting-table" class="table list"> 184 <ul id="whitelisting-table" class="table list">
185 <template> 185 <template>
186 <button class="delete control"></button> 186 <button class="delete control"></button>
187 <span class="display"></span> 187 <label class="display"></label>
188 </template> 188 </template>
189 </ul> 189 </ul>
190 <div class="controls"> 190 <div class="controls">
191 <button data-action="edit-domain-exception"> 191 <button data-action="edit-domain-exception">
192 <span class="icon icon-add"></span> 192 <span class="icon icon-add"></span>
193 <span class="i18n_options_whitelisted_add"></span> 193 <span class="i18n_options_whitelisted_add"></span>
194 </button> 194 </button>
195 <div> 195 <div>
196 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> 196 <span class="icon icon-add" data-action="add-domain-exceptio n"></span>
197 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" /> 197 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" />
(...skipping 14 matching lines...) Expand all
212 212
213 <!-- Advanced tab content --> 213 <!-- Advanced tab content -->
214 <div id="content-advanced" class="tab-content"> 214 <div id="content-advanced" class="tab-content">
215 <div> 215 <div>
216 <h1> 216 <h1>
217 <span class="i18n_options_tweaks_title"></span> 217 <span class="i18n_options_tweaks_title"></span>
218 <a class="i18n_options_readMore tooltip"></a> 218 <a class="i18n_options_readMore tooltip"></a>
219 </h1> 219 </h1>
220 <ul id="tweaks" class="table"> 220 <ul id="tweaks" class="table">
221 <li data-pref="shouldShowBlockElementMenu"> 221 <li data-pref="shouldShowBlockElementMenu">
222 <button role="checkbox" data-action="toggle-pref"></button> 222 <label>
223 <span class="i18n_options_tweaks_blockElement"></span> 223 <button role="checkbox" data-action="toggle-pref"></button>
224 <span class="i18n_options_tweaks_blockElement"></span>
225 </label>
224 </li> 226 </li>
225 <li data-pref="show_devtools_panel"> 227 <li data-pref="show_devtools_panel">
226 <button role="checkbox" data-action="toggle-pref"></button> 228 <label>
227 <span class="i18n_options_tweaks_showDevToolsPanel"></span> 229 <button role="checkbox" data-action="toggle-pref"></button>
230 <span class="i18n_options_tweaks_showDevToolsPanel"></span>
231 </label>
228 </li> 232 </li>
229 <li data-pref="notifications_ignoredcategories"> 233 <li data-pref="notifications_ignoredcategories">
230 <button role="checkbox" data-action="toggle-pref"></button> 234 <label>
231 <span class="i18n_options_tweaks_showNotifications"></span> 235 <button role="checkbox" data-action="toggle-pref"></button>
236 <span class="i18n_options_tweaks_showNotifications"></span>
237 </label>
232 </li> 238 </li>
233 <li data-pref="safari_contentblocker"> 239 <li data-pref="safari_contentblocker">
234 <button role="checkbox" data-action="toggle-pref"></button> 240 <label>
235 <span class="i18n_options_tweaks_safariContentBlocker"></span> 241 <button role="checkbox" data-action="toggle-pref"></button>
242 <span class="i18n_options_tweaks_safariContentBlocker"></span>
243 </label>
236 <span id="restart-safari" class="i18n_options_tweaks_restartSafa ri"></span> 244 <span id="restart-safari" class="i18n_options_tweaks_restartSafa ri"></span>
237 </li> 245 </li>
238 </ul> 246 </ul>
239 </div> 247 </div>
240 248
241 <div> 249 <div>
242 <h1> 250 <h1>
243 <span class="i18n_options_filterList_title"></span> 251 <span class="i18n_options_filterList_title"></span>
244 <a class="i18n_options_readMore tooltip"></a> 252 <a class="i18n_options_readMore tooltip"></a>
245 </h1> 253 </h1>
246 <ul class="tabs horizontal"> 254 <ul class="tabs horizontal">
247 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li> 255 <li class="i18n_options_tab_overview active" data-action="switch-t ab" data-tab="advanced-allFilterLists"></li>
248 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li> 256 <li class="i18n_options_tab_ownList" data-action="switch-tab" data -tab="advanced-customFilters"></li>
249 </ul> 257 </ul>
250 <div id="filter-lists"> 258 <div id="filter-lists">
251 <div id="all-filter-lists"> 259 <div id="all-filter-lists">
252 <div class="table-header"> 260 <div class="table-header">
253 <h3 class="i18n_options_column_name"></h3> 261 <h3 class="i18n_options_column_name"></h3>
254 <h3 class="i18n_options_column_date"></h3> 262 <h3 class="i18n_options_column_date"></h3>
255 </div> 263 </div>
256 <ul class="table cols" id="all-filter-lists-table"> 264 <ul class="table cols" id="all-filter-lists-table">
257 <template> 265 <template>
258 <button role="checkbox" class="control"></button> 266 <button role="checkbox" class="control"></button>
259 <div> 267 <div>
260 <span data-action="open-context-menu" class="display"></sp an> 268 <label data-action="open-context-menu" class="display"></l abel>
261 <div data-action="open-context-menu" class="arrow"> 269 <div data-action="open-context-menu" class="arrow">
262 <div class="context-menu"> 270 <div class="context-menu">
263 <div class="content"> 271 <div class="content">
264 <a class="i18n_options_filterList_updateNow update-s ubscription" data-action="update-subscription"></a> 272 <a class="i18n_options_filterList_updateNow update-s ubscription" data-action="update-subscription"></a>
265 <a class="i18n_options_filterList_website website" t arget="_blank"></a> 273 <a class="i18n_options_filterList_website website" t arget="_blank"></a>
266 <a class="i18n_options_filterList_source source" tar get="_blank"></a> 274 <a class="i18n_options_filterList_source source" tar get="_blank"></a>
267 <a class="i18n_options_filterList_delete delete" dat a-action="remove-subscription"></a> 275 <a class="i18n_options_filterList_delete delete" dat a-action="remove-subscription"></a>
268 </div> 276 </div>
269 </div> 277 </div>
270 </div> 278 </div>
(...skipping 22 matching lines...) Expand all
293 <span class="i18n_options_filterList_update"></span> 301 <span class="i18n_options_filterList_update"></span>
294 </button> 302 </button>
295 </div> 303 </div>
296 </div> 304 </div>
297 <div id="custom-filters"> 305 <div id="custom-filters">
298 <h3 id="custom-filters-header" class="i18n_options_customFilters _title"></h3> 306 <h3 id="custom-filters-header" class="i18n_options_customFilters _title"></h3>
299 <div id="custom-filters-wrapper"> 307 <div id="custom-filters-wrapper">
300 <div id="custom-filters-list-wrapper"> 308 <div id="custom-filters-list-wrapper">
301 <ul id="custom-filters-table" class="table list"> 309 <ul id="custom-filters-table" class="table list">
302 <template> 310 <template>
303 <span class="display"></span> 311 <label class="display"></label>
304 </template> 312 </template>
305 </ul> 313 </ul>
306 <form id="custom-filters-add" class="controls"> 314 <form id="custom-filters-add" class="controls">
307 <input type="text"/> 315 <input type="text"/>
308 <button class="i18n_options_button_add" type="submit"></bu tton> 316 <button class="i18n_options_button_add" type="submit"></bu tton>
309 </form> 317 </form>
310 </div> 318 </div>
311 <textarea id="custom-filters-raw"></textarea> 319 <textarea id="custom-filters-raw"></textarea>
312 </div> 320 </div>
313 <div id="custom-filters-edit-wrapper" class="controls"> 321 <div id="custom-filters-edit-wrapper" class="controls">
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 </span> 372 </span>
365 <button id="dialog-close" class="i18n_options_close focus-first" data-ac tion="close-dialog"></button> 373 <button id="dialog-close" class="i18n_options_close focus-first" data-ac tion="close-dialog"></button>
366 </header> 374 </header>
367 <div id="dialog-body" class="content"> 375 <div id="dialog-body" class="content">
368 <!-- Add language subscription --> 376 <!-- Add language subscription -->
369 <div id="dialog-content-language" class="dialog-content"> 377 <div id="dialog-content-language" class="dialog-content">
370 <div class="dialog-content-block"> 378 <div class="dialog-content-block">
371 <h3 class="i18n_options_dialog_language_added"></h3> 379 <h3 class="i18n_options_dialog_language_added"></h3>
372 <ul id="blocking-languages-dialog-table" class="table list"> 380 <ul id="blocking-languages-dialog-table" class="table list">
373 <template> 381 <template>
374 <span class="display"></span> 382 <label class="display"></label>
375 </template> 383 </template>
376 </ul> 384 </ul>
377 </div> 385 </div>
378 <div id="other-language" class="dialog-content-block"> 386 <div id="other-language" class="dialog-content-block">
379 <div> 387 <div>
380 <label for="find-language" class="i18n_options_dialog_language_oth er"></label> 388 <label for="find-language" class="i18n_options_dialog_language_oth er"></label>
381 <input type="search" id="find-language" class="default-focus" /> 389 <input type="search" id="find-language" class="default-focus" />
382 </div> 390 </div>
383 <ul id="all-lang-table" class="table list"> 391 <ul id="all-lang-table" class="table list">
384 <template> 392 <template>
385 <button class="button-add control"> 393 <button class="button-add control">
386 +<span class="i18n_options_button_add"></span> 394 +<span class="i18n_options_button_add"></span>
387 </button> 395 </button>
388 <span class="display"></span> 396 <label class="display"></label>
389 </template> 397 </template>
390 </ul> 398 </ul>
391 </div> 399 </div>
392 </div> 400 </div>
393 <!-- Add custom subscription --> 401 <!-- Add custom subscription -->
394 <div id="dialog-content-custom" class="dialog-content"> 402 <div id="dialog-content-custom" class="dialog-content">
395 <div class="dialog-content-block"> 403 <div class="dialog-content-block">
396 <div> 404 <div>
397 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label> 405 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label>
398 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" /> 406 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" />
(...skipping 12 matching lines...) Expand all
411 <div class="url"></div> 419 <div class="url"></div>
412 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 420 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
413 </div> 421 </div>
414 </div> 422 </div>
415 </div> 423 </div>
416 <!-- Placeholder element to determine when to wrap focus around --> 424 <!-- Placeholder element to determine when to wrap focus around -->
417 <span class="focus-last" tabindex="0"></span> 425 <span class="focus-last" tabindex="0"></span>
418 </div> 426 </div>
419 </body> 427 </body>
420 </html> 428 </html>
OLDNEW
« no previous file with comments | « no previous file | options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld