Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: options.html

Issue 29339231: Issue 3882 - Make checkbox labels sensitive on the option page (Closed)
Left Patch Set: Created March 31, 2016, 4:39 p.m.
Right Patch Set: Use <label> more consistently Created April 1, 2016, 1:33 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2016 Eyeo GmbH 4 - Copyright (C) 2006-2016 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 <ul id="recommend-list-table" class="table list"> 123 <ul id="recommend-list-table" class="table list">
124 <template> 124 <template>
125 <button role="checkbox" class="control"></button> 125 <button role="checkbox" class="control"></button>
126 <label class="display"></label> 126 <label class="display"></label>
127 <span class="i18n_options_popular popular"></span> 127 <span class="i18n_options_popular popular"></span>
128 </template> 128 </template>
129 </ul> 129 </ul>
130 <ul id="custom-list-table" class="table list"> 130 <ul id="custom-list-table" class="table list">
131 <template> 131 <template>
132 <button role="checkbox" class="control"></button> 132 <button role="checkbox" class="control"></button>
133 <span class="display"></span> 133 <label class="display"></label>
134 </template> 134 </template>
135 </ul> 135 </ul>
136 </div> 136 </div>
137 <div class="controls"> 137 <div class="controls">
138 <button data-action="open-dialog" data-dialog="custom"> 138 <button data-action="open-dialog" data-dialog="custom">
139 <span class="icon icon-add"></span> 139 <span class="icon icon-add"></span>
140 <span class="i18n_options_furtherBlocking_add"><span> 140 <span class="i18n_options_furtherBlocking_add"><span>
141 </button> 141 </button>
142 </div> 142 </div>
143 </div> 143 </div>
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 <p class="i18n_options_whitelisted_title_tooltip_2"></p> 177 <p class="i18n_options_whitelisted_title_tooltip_2"></p>
178 <div class="notes"> 178 <div class="notes">
179 <p class="i18n_options_whitelisted_title_tooltip_notes"> </p> 179 <p class="i18n_options_whitelisted_title_tooltip_notes"> </p>
180 </div> 180 </div>
181 </div> 181 </div>
182 </div> 182 </div>
183 </div> 183 </div>
184 <ul id="whitelisting-table" class="table list"> 184 <ul id="whitelisting-table" class="table list">
185 <template> 185 <template>
186 <button class="delete control"></button> 186 <button class="delete control"></button>
187 <span class="display"></span> 187 <label class="display"></label>
188 </template> 188 </template>
189 </ul> 189 </ul>
190 <div class="controls"> 190 <div class="controls">
191 <button data-action="edit-domain-exception"> 191 <button data-action="edit-domain-exception">
192 <span class="icon icon-add"></span> 192 <span class="icon icon-add"></span>
193 <span class="i18n_options_whitelisted_add"></span> 193 <span class="i18n_options_whitelisted_add"></span>
194 </button> 194 </button>
195 <div> 195 <div>
196 <span class="icon icon-add" data-action="add-domain-exceptio n"></span> 196 <span class="icon icon-add" data-action="add-domain-exceptio n"></span>
197 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" /> 197 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" />
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 <div id="filter-lists"> 258 <div id="filter-lists">
259 <div id="all-filter-lists"> 259 <div id="all-filter-lists">
260 <div class="table-header"> 260 <div class="table-header">
261 <h3 class="i18n_options_column_name"></h3> 261 <h3 class="i18n_options_column_name"></h3>
262 <h3 class="i18n_options_column_date"></h3> 262 <h3 class="i18n_options_column_date"></h3>
263 </div> 263 </div>
264 <ul class="table cols" id="all-filter-lists-table"> 264 <ul class="table cols" id="all-filter-lists-table">
265 <template> 265 <template>
266 <button role="checkbox" class="control"></button> 266 <button role="checkbox" class="control"></button>
267 <div> 267 <div>
268 <span data-action="open-context-menu" class="display"></sp an> 268 <label data-action="open-context-menu" class="display"></l abel>
269 <div data-action="open-context-menu" class="arrow"> 269 <div data-action="open-context-menu" class="arrow">
270 <div class="context-menu"> 270 <div class="context-menu">
271 <div class="content"> 271 <div class="content">
272 <a class="i18n_options_filterList_updateNow update-s ubscription" data-action="update-subscription"></a> 272 <a class="i18n_options_filterList_updateNow update-s ubscription" data-action="update-subscription"></a>
273 <a class="i18n_options_filterList_website website" t arget="_blank"></a> 273 <a class="i18n_options_filterList_website website" t arget="_blank"></a>
274 <a class="i18n_options_filterList_source source" tar get="_blank"></a> 274 <a class="i18n_options_filterList_source source" tar get="_blank"></a>
275 <a class="i18n_options_filterList_delete delete" dat a-action="remove-subscription"></a> 275 <a class="i18n_options_filterList_delete delete" dat a-action="remove-subscription"></a>
276 </div> 276 </div>
277 </div> 277 </div>
278 </div> 278 </div>
(...skipping 22 matching lines...) Expand all
301 <span class="i18n_options_filterList_update"></span> 301 <span class="i18n_options_filterList_update"></span>
302 </button> 302 </button>
303 </div> 303 </div>
304 </div> 304 </div>
305 <div id="custom-filters"> 305 <div id="custom-filters">
306 <h3 id="custom-filters-header" class="i18n_options_customFilters _title"></h3> 306 <h3 id="custom-filters-header" class="i18n_options_customFilters _title"></h3>
307 <div id="custom-filters-wrapper"> 307 <div id="custom-filters-wrapper">
308 <div id="custom-filters-list-wrapper"> 308 <div id="custom-filters-list-wrapper">
309 <ul id="custom-filters-table" class="table list"> 309 <ul id="custom-filters-table" class="table list">
310 <template> 310 <template>
311 <span class="display"></span> 311 <label class="display"></label>
312 </template> 312 </template>
313 </ul> 313 </ul>
314 <form id="custom-filters-add" class="controls"> 314 <form id="custom-filters-add" class="controls">
315 <input type="text"/> 315 <input type="text"/>
316 <button class="i18n_options_button_add" type="submit"></bu tton> 316 <button class="i18n_options_button_add" type="submit"></bu tton>
317 </form> 317 </form>
318 </div> 318 </div>
319 <textarea id="custom-filters-raw"></textarea> 319 <textarea id="custom-filters-raw"></textarea>
320 </div> 320 </div>
321 <div id="custom-filters-edit-wrapper" class="controls"> 321 <div id="custom-filters-edit-wrapper" class="controls">
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 </span> 372 </span>
373 <button id="dialog-close" class="i18n_options_close focus-first" data-ac tion="close-dialog"></button> 373 <button id="dialog-close" class="i18n_options_close focus-first" data-ac tion="close-dialog"></button>
374 </header> 374 </header>
375 <div id="dialog-body" class="content"> 375 <div id="dialog-body" class="content">
376 <!-- Add language subscription --> 376 <!-- Add language subscription -->
377 <div id="dialog-content-language" class="dialog-content"> 377 <div id="dialog-content-language" class="dialog-content">
378 <div class="dialog-content-block"> 378 <div class="dialog-content-block">
379 <h3 class="i18n_options_dialog_language_added"></h3> 379 <h3 class="i18n_options_dialog_language_added"></h3>
380 <ul id="blocking-languages-dialog-table" class="table list"> 380 <ul id="blocking-languages-dialog-table" class="table list">
381 <template> 381 <template>
382 <span class="display"></span> 382 <label class="display"></label>
383 </template> 383 </template>
384 </ul> 384 </ul>
385 </div> 385 </div>
386 <div id="other-language" class="dialog-content-block"> 386 <div id="other-language" class="dialog-content-block">
387 <div> 387 <div>
388 <label for="find-language" class="i18n_options_dialog_language_oth er"></label> 388 <label for="find-language" class="i18n_options_dialog_language_oth er"></label>
389 <input type="search" id="find-language" class="default-focus" /> 389 <input type="search" id="find-language" class="default-focus" />
390 </div> 390 </div>
391 <ul id="all-lang-table" class="table list"> 391 <ul id="all-lang-table" class="table list">
392 <template> 392 <template>
393 <button class="button-add control"> 393 <button class="button-add control">
394 +<span class="i18n_options_button_add"></span> 394 +<span class="i18n_options_button_add"></span>
395 </button> 395 </button>
396 <span class="display"></span> 396 <label class="display"></label>
397 </template> 397 </template>
398 </ul> 398 </ul>
399 </div> 399 </div>
400 </div> 400 </div>
401 <!-- Add custom subscription --> 401 <!-- Add custom subscription -->
402 <div id="dialog-content-custom" class="dialog-content"> 402 <div id="dialog-content-custom" class="dialog-content">
403 <div class="dialog-content-block"> 403 <div class="dialog-content-block">
404 <div> 404 <div>
405 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label> 405 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label>
406 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" /> 406 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" />
(...skipping 12 matching lines...) Expand all
419 <div class="url"></div> 419 <div class="url"></div>
420 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 420 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
421 </div> 421 </div>
422 </div> 422 </div>
423 </div> 423 </div>
424 <!-- Placeholder element to determine when to wrap focus around --> 424 <!-- Placeholder element to determine when to wrap focus around -->
425 <span class="focus-last" tabindex="0"></span> 425 <span class="focus-last" tabindex="0"></span>
426 </div> 426 </div>
427 </body> 427 </body>
428 </html> 428 </html>
LEFTRIGHT
« no previous file | options.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld