Issue 3884 - Show original subscription title in the Advanced tab of the options page

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 150 matching lines @@
   Collection.prototype.updateItem = function(item)
   {
     var access = (item.url || item.text).replace(/'/g, "\\'");
     for (var i = 0; i < this.details.length; i++)
     {
       var table = E(this.details[i].id);
       var element = table.querySelector("[data-access='" + access + "']");
       if (!element)
         continue;
 
-      var title = item.title || item.url || item.text;
+      var title = null;
+      if (this.details[i].useOriginalTitle)
+        title = item.originalTitle;
+      if (!title)
+        title = item.title || item.url || item.text;
       element.querySelector(".display").textContent = title;
       if (title)
         element.setAttribute("data-search", title.toLowerCase());
       var control = element.querySelector(".control[role='checkbox']");
       if (control)
         control.setAttribute("aria-checked", item.disabled == false);
 
       var downloadStatus = item.downloadStatus;
       var dateElement = element.querySelector(".date");
       var timeElement = element.querySelector(".time");
@@ skipping 169 matching lines @@
   [
     {
       id: "custom-filters-table",
       emptyText: "options_customFilters_empty"
     }
   ]);
   collections.filterLists = new Collection(
   [
     {
       id: "all-filter-lists-table",
-      onClick: toggleDisableSubscription
+      onClick: toggleDisableSubscription,
+      useOriginalTitle: true
     }
   ]);
 
   function observeSubscription(subscription)
   {
     function onObjectChanged(change)
     {
       for (var i = 0; i < change.length; i++)
       {
         if (change[i].name == "disabled")
@@ skipping 109 matching lines @@
       })
       .then(function(text)
       {
         var list = document.getElementById("subscriptionSelector");
         var doc = new DOMParser().parseFromString(text, "application/xml");
         var elements = doc.documentElement.getElementsByTagName("subscription");
         for (var i = 0; i < elements.length; i++)
         {
           var element = elements[i];
           var subscription = Object.create(null);
-          subscription.title = element.getAttribute("title");
+          subscription.originalTitle = element.getAttribute("title");
           subscription.url = element.getAttribute("url");
           subscription.disabled = null;
           subscription.downloadStatus = null;
           subscription.homepage = null;
           var recommendation = Object.create(null);
           recommendation.type = element.getAttribute("type");
           var prefix = element.getAttribute("prefixes");
           if (prefix)
           {
             prefix = prefix.replace(/\W/g, "_");
@@ skipping 339 matching lines @@
             updateFilter(filters[i]);
         });
       }
     });
     loadRecommendations();
     getAcceptableAdsURL(function(acceptableAdsUrl)
     {
       var subscription = Object.create(null);
       subscription.url = acceptableAdsUrl;
       subscription.disabled = true;
       subscription.title = getMessage("options_acceptableAds_description");

[saroyanm, 2016/04/01 15:17:50]

I think we also should specify original title here.

[Sebastian Noack, 2016/04/01 15:20:37]

If I don't miss something we don't have the original title here. Not that it
matters much for this subscription.

[saroyanm, 2016/04/01 15:33:54]

Well, currently AA title is "Allow non-intrusive advertising" in filter list,
while we using "Allow some non-intrusive advertising", also this will be only
item in advanced tab that will be translatable with current implementation. So I
think this should behave same way as other subscriptions, not sure why this item
should behave differently.

[Sebastian Noack, 2016/04/01 15:55:02]

Well, "Own filter list", referring to the SpecialSubscription for the custom
filters, is also translated in that list. Also one could argue that "Allow some
non-intrusive advertising" should be consistently translated, since the name
only differs in a single word as opposed to the other aliased/translated
subscription titles. I don't have a strong opinion though, though I mildly lend
towards leaving it as it is, if it's just to keep it simple.

       updateSubscription(subscription);
 
       // Load user subscriptions
       ext.backgroundPage.sendMessage(
       {
         type: "subscriptions.get",
         downloadable: true
       }, 
       function(subscriptions)
       {
@@ skipping 282 matching lines @@
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
         "title"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();