Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339287: Issue 3885 - Disable the checkbox to toggle the Acceptable Ads list on the options page (Closed)

Created:
April 1, 2016, 3:40 p.m. by Sebastian Noack
Modified:
April 15, 2016, 4:54 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3885 - Disable the checkbox to toggle the Acceptable Ads list on the options page

Patch Set 1 #

Total comments: 4

Patch Set 2 : Put disabled items to the bottom of the list #

Total comments: 2

Patch Set 3 : Simplified logic, got rid of getAcceptableAdsURL() #

Patch Set 4 : Rebased #

Total comments: 4

Patch Set 5 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -61 lines) Patch
M options.js View 1 2 3 4 8 chunks +71 lines, -61 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
https://codereview.adblockplus.org/29339287/diff/29339288/options.js File options.js (right): https://codereview.adblockplus.org/29339287/diff/29339288/options.js#newcode908 options.js:908: getPref("subscriptions_exceptionsurl", callback); Unrelated, but I couldn't resits. WTF?
April 1, 2016, 3:41 p.m. (2016-04-01 15:41:56 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29339287/diff/29339293/locale/en-US/options.json File locale/en-US/options.json (left): https://codereview.adblockplus.org/29339287/diff/29339293/locale/en-US/options.json#oldcode143 locale/en-US/options.json:143: "description": "Show block Element option in Advanced tab", This ...
April 1, 2016, 6:22 p.m. (2016-04-01 18:22:01 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29339287/diff/29339296/options.js File options.js (right): https://codereview.adblockplus.org/29339287/diff/29339296/options.js#newcode89 options.js:89: var aDisabled = this._isControlDisabled(a, 0); This makes sure that ...
April 1, 2016, 6:26 p.m. (2016-04-01 18:26:43 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29339287/diff/29339288/options.js File options.js (right): https://codereview.adblockplus.org/29339287/diff/29339288/options.js#newcode908 options.js:908: getPref("subscriptions_exceptionsurl", callback); On 2016/04/01 15:41:56, Sebastian Noack wrote: > ...
April 6, 2016, 5:15 p.m. (2016-04-06 17:15:41 UTC) #4
Thomas Greiner
https://codereview.adblockplus.org/29339287/diff/29339288/options.js File options.js (right): https://codereview.adblockplus.org/29339287/diff/29339288/options.js#newcode908 options.js:908: getPref("subscriptions_exceptionsurl", callback); On 2016/04/06 17:15:41, Sebastian Noack wrote: > ...
April 7, 2016, 5:21 p.m. (2016-04-07 17:21:15 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29339287/diff/29339288/options.js File options.js (right): https://codereview.adblockplus.org/29339287/diff/29339288/options.js#newcode908 options.js:908: getPref("subscriptions_exceptionsurl", callback); On 2016/04/07 17:21:15, Thomas Greiner wrote: > ...
April 8, 2016, 2:22 p.m. (2016-04-08 14:22:17 UTC) #6
Thomas Greiner
April 15, 2016, 1:23 p.m. (2016-04-15 13:23:32 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld