Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339320: Issue 3887 - Support bringing up the new options page with a specific tab focused (Closed)

Created:
April 3, 2016, 3 p.m. by Sebastian Noack
Modified:
April 6, 2016, 11 p.m.
Reviewers:
Thomas Greiner
CC:
kzar
Visibility:
Public.

Description

Issue 3887 - Support bringing up the new options page with a specific tab focused

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Rename switchToOptionsSection to focusSection #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M options.js View 1 2 chunks +12 lines, -7 lines 1 comment Download

Messages

Total messages: 6
Sebastian Noack
April 3, 2016, 3:01 p.m. (2016-04-03 15:01:23 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29339320/diff/29339341/options.js File options.js (right): https://codereview.adblockplus.org/29339320/diff/29339341/options.js#newcode1138 options.js:1138: case "switchToOptionsSection": Detail: Is this specific to the options ...
April 4, 2016, 12:46 p.m. (2016-04-04 12:46:36 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29339320/diff/29339341/options.js File options.js (right): https://codereview.adblockplus.org/29339320/diff/29339341/options.js#newcode1138 options.js:1138: case "switchToOptionsSection": On 2016/04/04 12:46:36, Thomas Greiner wrote: > ...
April 5, 2016, 1:32 p.m. (2016-04-05 13:32:02 UTC) #3
Thomas Greiner
https://codereview.adblockplus.org/29339320/diff/29339341/options.js File options.js (right): https://codereview.adblockplus.org/29339320/diff/29339341/options.js#newcode1138 options.js:1138: case "switchToOptionsSection": On 2016/04/05 13:32:02, Sebastian Noack wrote: > ...
April 6, 2016, 12:49 p.m. (2016-04-06 12:49:13 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29339320/diff/29339341/options.js File options.js (right): https://codereview.adblockplus.org/29339320/diff/29339341/options.js#newcode1138 options.js:1138: case "switchToOptionsSection": On 2016/04/06 12:49:12, Thomas Greiner wrote: > ...
April 6, 2016, 5:38 p.m. (2016-04-06 17:38:29 UTC) #5
Thomas Greiner
April 6, 2016, 6:05 p.m. (2016-04-06 18:05:08 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld