Noissue - Removed redundant URL compatibility logic

lib/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 201 matching lines @@
         if (shown instanceof Array && shown.indexOf(notification.id) != -1)
           continue;
         if (Prefs.notifications_ignoredcategories.indexOf("*") != -1)
           continue;
       }
 
       if (typeof url === "string" || notification.urlFilters instanceof Array)
       {
         if (Prefs.enabled && typeof url === "string" && notification.urlFilters instanceof Array)
         {
-          let host;
-          if (typeof URL == "function")
-            host = new URL(url).hostname;
-          else
-          {
-            try
-            {
-              host = Services.io.newURI(url, null, null).host;
-            }
-            catch (e)
-            {
-              // Ignore, an exception is expected for about: and similar schemes
-              host = "";
-            }
-          }
+          let uri = Utils.makeURI(url);

[Sebastian Noack, 2016/04/04 11:19:46]

Utils.makeURI() wraps Services.io.newURI() and returns null if an exception is
raised. Moreover, as it's also used by the synchronizer, it therefore already
has implementations for other platforms like Chrome.

[Wladimir Palant, 2016/04/04 12:57:36]

Actually, it is better to use `new URL` unconditionally - it has been added in
https://issues.adblockplus.org/ticket/3834 and can be expected to exist on
Firefox as well.

[Sebastian Noack, 2016/04/04 13:40:38]

Awesome. New patch set is up.

+          let host = uri && uri.host || "";
+
           let exception = defaultMatcher.matchesAny(url, RegExpFilter.typeMap.DOCUMENT, host, false, null);
           if (exception instanceof WhitelistFilter)
             continue;
 
           let matcher = new Matcher();
           for (let urlFilter of notification.urlFilters)
             matcher.add(Filter.fromText(urlFilter));
           if (!matcher.matchesAny(url, RegExpFilter.typeMap.DOCUMENT, host, false, null))
             continue;
         }
@@ skipping 156 matching lines @@
       Prefs.notifications_showui = true;
     }
     else if (index != -1 && forceValue !== true)
       categories.splice(index, 1);
 
     // HACK: JSON values aren't saved unless they are assigned a different object.
     Prefs.notifications_ignoredcategories = JSON.parse(JSON.stringify(categories));
   }
 };
 Notification.init();