lib/synchronizer.js - Issue 29339343: Noissue - Removed redundant URL compatibility logic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/synchronizer.js

Issue 29339343: Noissue - Removed redundant URL compatibility logic (Closed)

Patch Set: Always use URL Created April 4, 2016, 1:39 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/synchronizer.js

===================================================================

--- a/lib/synchronizer.js

+++ b/lib/synchronizer.js

@@ -206,9 +206,18 @@

// Process parameters

if (params.homepage)

{

- let uri = Utils.makeURI(params.homepage);

- if (uri && (uri.scheme == "http" || uri.scheme == "https"))

- subscription.homepage = uri.spec;

+ let url;

+ try

+ {

+ url = new URL(params.homepage);

+ }

+ catch (e)

+ {

+ url = null;

+ }

+ if (url && (url.protocol == "http" || url.protocol == "https"))

+ subscription.homepage = url.href;

}

if (params.title)

« no previous file with comments | « lib/notification.js ('k') | no next file » | no next file with comments »