Unified Diff: background.js
Issue 29339387:
Issue 3890 - Fix "Downloading..." indication for subscriptions on the options page (Closed)
Patch Set:
Created April 5, 2016, 5:26 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
messageResponder.js » ('j')
|
messageResponder.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: background.js |
| =================================================================== |
| --- a/background.js |
| +++ b/background.js |
| @@ -287,8 +287,8 @@ |
| _downloading: false, |
| execute: function(subscription, manual) |
| { |
| - subscription.lastDownload = 0; |
|
Sebastian Noack
2016/04/05 18:38:48
This was wrong. The lastDownload property isn't re
|
| modules.synchronizer.Synchronizer._downloading = true; |
| + modules.filterNotifier.FilterNotifier.emit("subscription.downloading", subscription); |
|
kzar
2016/04/06 08:53:37
Nit: Mind breaking this long line at the comma?
Sebastian Noack
2016/04/06 09:13:00
Done.
|
| setTimeout(function() |
| { |
| modules.synchronizer.Synchronizer._downloading = false; |
« no previous file with comments
|
« no previous file
|
messageResponder.js » ('j')
|
messageResponder.js » ('J')
