Issue 3890 - Fix "Downloading..." indication for subscriptions on the options page

messageResponder.js

Index: messageResponder.js
===================================================================
--- a/messageResponder.js
+++ b/messageResponder.js
@@ -64,8 +64,14 @@
     return result;
   }
 
-  var convertSubscription = convertObject.bind(null, ["disabled",
-    "downloadStatus", "homepage", "lastDownload", "title", "url"]);
+  function convertSubscription(subscription)
+  {
+    var obj = convertObject(["disabled", "downloadStatus", "homepage",
+                             "lastDownload", "title", "url"], subscription);
+    obj.isDownloading = Synchronizer.isExecuting(subscription);

[Thomas Greiner, 2016/04/06 14:19:43]

`Synchronizer.isExecuting()` is expecting a URL but you're passing in an object
so that shouldn't work from what I see.

[Sebastian Noack, 2016/04/06 17:22:22]

Well spotted. Done.

+    return obj;
+  }
+
   var convertFilter = convertObject.bind(null, ["text"]);
 
   var changeListeners = new global.ext.PageMap();
@@ -396,9 +402,6 @@
             Synchronizer.execute(subscription, true);
         }
         break;
-      case "subscriptions.isDownloading":
-        callback(Synchronizer.isExecuting(message.url));
-        break;
     }
   });
 })(this);