Unified Diff: messageResponder.js
Issue 29339387:
Issue 3890 - Fix "Downloading..." indication for subscriptions on the options page (Closed)
Patch Set: Pass URL to Synchronizer.isExecuting()
Created April 6, 2016, 5:20 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« background.js ('k')
|
options.js » ('j')
|
options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: messageResponder.js |
| =================================================================== |
| --- a/messageResponder.js |
| +++ b/messageResponder.js |
| @@ -64,8 +64,14 @@ |
| return result; |
| } |
| - var convertSubscription = convertObject.bind(null, ["disabled", |
| - "downloadStatus", "homepage", "lastDownload", "title", "url"]); |
| + function convertSubscription(subscription) |
| + { |
| + var obj = convertObject(["disabled", "downloadStatus", "homepage", |
| + "lastDownload", "title", "url"], subscription); |
| + obj.isDownloading = Synchronizer.isExecuting(subscription.url); |
| + return obj; |
| + } |
| + |
| var convertFilter = convertObject.bind(null, ["text"]); |
| var changeListeners = new global.ext.PageMap(); |
| @@ -396,9 +402,6 @@ |
| Synchronizer.execute(subscription, true); |
| } |
| break; |
| - case "subscriptions.isDownloading": |
| - callback(Synchronizer.isExecuting(message.url)); |
| - break; |
| } |
| }); |
| })(this); |
