Noissue - Make the options page respond to subscription title and homepage changes

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 426 matching lines @@
       Object.observe(subscription, onObjectChanged);
     }
   }
 
   function updateSubscription(subscription)
   {
     var subscriptionUrl = subscription.url;
     var knownSubscription = subscriptionsMap[subscriptionUrl];
     if (knownSubscription)
     {
       for (var property in subscription)

[Thomas Greiner, 2016/04/06 13:51:18]

Detail: I know that this is valid JavaScript and I'm aware that we don't have
anything in that regard in the coding styles but it's a bit strange seeing this
Python-looking block in JavaScript because usually you would put braces around
blocks that include multiple lines.

It might be comparable to putting multiple statements into a single line (e.g.
`foo(), bar();`) which we would usually avoid even though it is valid JavaScript
and our coding style allows it.

[Sebastian Noack, 2016/04/06 17:26:29]

Done.

-        if (property != "title")
+        if (property == "title" && subscription.url in recommendationsMap)

[Thomas Greiner, 2016/04/06 13:51:18]

Detail: I noticed that there's a variable `subscriptionsUrl` above. Feel free to
decide whether you want to reuse (and rename) or remove it.

[Sebastian Noack, 2016/04/06 17:26:29]

Done.

+          knownSubscription.originalTitle = subscription.title;
+        else
           knownSubscription[property] = subscription[property];
     }
     else
     {
       observeSubscription(subscription);
       getAcceptableAdsURL(function(acceptableAdsUrl)
       {
         var collection = null;
         if (subscriptionUrl in recommendationsMap)
         {
@@ skipping 509 matching lines @@
         var knownSubscription = subscriptionsMap[subscription.url];
         if (knownSubscription)
           collections.filterLists.addItems(knownSubscription);
         else
           collections.filterLists.addItems(subscription);
         break;
       case "disabled":
         updateSubscription(subscription);
         updateShareLink();
         break;
-      case "lastDownload":
-      case "downloadStatus":
-      case "downloading":
-        updateSubscription(subscription);
-        break;
-      case "homepage":
-        // TODO: NYI
-        break;
       case "removed":
         var knownSubscription = subscriptionsMap[subscription.url];
         getAcceptableAdsURL(function(acceptableAdsUrl)
         {
           if (subscription.url == acceptableAdsUrl)
           {
             subscription.disabled = true;
             updateSubscription(subscription);
           }
           else
           {
             if (subscription.url in recommendationsMap)
               knownSubscription.disabled = true;
             else
             {
               collections.custom.removeItem(knownSubscription);
               delete subscriptionsMap[subscription.url];
             }
           }
           updateShareLink();
           collections.filterLists.removeItem(knownSubscription);
         });
         break;
-      case "title":
-        // TODO: NYI
+      default:
+        updateSubscription(subscription);
         break;
     }
   }
 
   function hidePref(key, value)
   {
     var element = document.querySelector("[data-pref='" + key + "']");
     if (element)
       element.setAttribute("aria-hidden", value);
   }
@@ skipping 143 matching lines @@
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
         "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();