Unified Diff: options.js
Issue 29339395:
Noissue - Make the options page respond to subscription title and homepage changes (Closed)
Patch Set: Addressed comments
Created April 6, 2016, 5:25 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« messageResponder.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.js |
| =================================================================== |
| --- a/options.js |
| +++ b/options.js |
| @@ -445,8 +445,12 @@ |
| if (knownSubscription) |
| { |
| for (var property in subscription) |
| - if (property != "title") |
| + { |
| + if (property == "title" && subscriptionUrl in recommendationsMap) |
| + knownSubscription.originalTitle = subscription.title; |
| + else |
| knownSubscription[property] = subscription[property]; |
| + } |
| } |
| else |
| { |
| @@ -982,14 +986,6 @@ |
| updateSubscription(subscription); |
| updateShareLink(); |
| break; |
| - case "lastDownload": |
| - case "downloadStatus": |
| - case "downloading": |
| - updateSubscription(subscription); |
| - break; |
| - case "homepage": |
| - // TODO: NYI |
| - break; |
| case "removed": |
| var knownSubscription = subscriptionsMap[subscription.url]; |
| getAcceptableAdsURL(function(acceptableAdsUrl) |
| @@ -1013,8 +1009,8 @@ |
| collections.filterLists.removeItem(knownSubscription); |
| }); |
| break; |
| - case "title": |
| - // TODO: NYI |
| + default: |
| + updateSubscription(subscription); |
| break; |
| } |
| } |
« no previous file with comments
|
« messageResponder.js ('k')
|
no next file »
|
no next file with comments »
