Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(339)

Issue 29339527: Issue 3892 - Disable button if input is invalid when adding subscriptions or filters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Sebastian Noack
Modified:
2 years, 6 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3892 - Disable button if input is invalid when adding subscriptions or filters

Patch Set 1 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -17 lines) Patch
M options.html View 2 chunks +2 lines, -2 lines 1 comment Download
M options.js View 5 chunks +23 lines, -9 lines 1 comment Download
M skin/options.css View 5 chunks +22 lines, -6 lines 2 comments Download
M skin/options-sprite.png View Binary file 0 comments Download

Messages

Total messages: 2
Sebastian Noack
https://codereview.adblockplus.org/29339527/diff/29339533/options.html File options.html (right): https://codereview.adblockplus.org/29339527/diff/29339533/options.html#newcode406 options.html:406: <input id="blockingList-textbox" type="url" required="true" pattern="https?://.+" class="default-focus" placeholder="https://example.com/blockinglist.txt" /> Two ...
3 years, 8 months ago (2016-04-06 22:46:02 UTC) #1
Sebastian Noack
2 years, 6 months ago (2017-05-22 13:28:46 UTC) #2
Closing this issue unmerged, as this change is no longer relevant with the new
design. See the related discussion in the issue tracker.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5