Side by Side Diff: options.html
Issue 29339527:
Issue 3892 - Disable button if input is invalid when adding subscriptions or filters (Closed)
Patch Set:
Created April 6, 2016, 10:43 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
options.js » ('j')
|
options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-2016 Eyeo GmbH | 4 - Copyright (C) 2006-2016 Eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 305 <div id="custom-filters"> | 305 <div id="custom-filters"> |
| 306 <h3 id="custom-filters-header" class="i18n_options_customFilters _title"></h3> | 306 <h3 id="custom-filters-header" class="i18n_options_customFilters _title"></h3> |
| 307 <div id="custom-filters-wrapper"> | 307 <div id="custom-filters-wrapper"> |
| 308 <div id="custom-filters-list-wrapper"> | 308 <div id="custom-filters-list-wrapper"> |
| 309 <ul id="custom-filters-table" class="table list"> | 309 <ul id="custom-filters-table" class="table list"> |
| 310 <template> | 310 <template> |
| 311 <label class="display"></label> | 311 <label class="display"></label> |
| 312 </template> | 312 </template> |
| 313 </ul> | 313 </ul> |
| 314 <form id="custom-filters-add" class="controls"> | 314 <form id="custom-filters-add" class="controls"> |
| 315 <input type="text"/> | 315 <input type="text" required="true" pattern=".*\S.*"/> |
| 316 <button class="i18n_options_button_add" type="submit"></bu tton> | 316 <button class="i18n_options_button_add" type="submit"></bu tton> |
| 317 </form> | 317 </form> |
| 318 </div> | 318 </div> |
| 319 <textarea id="custom-filters-raw"></textarea> | 319 <textarea id="custom-filters-raw"></textarea> |
| 320 </div> | 320 </div> |
| 321 <div id="custom-filters-edit-wrapper" class="controls"> | 321 <div id="custom-filters-edit-wrapper" class="controls"> |
| 322 <button id="custom-filters-show-edit" data-action="edit-custom -filters"> | 322 <button id="custom-filters-show-edit" data-action="edit-custom -filters"> |
| 323 <span class="icon icon-edit"></span> | 323 <span class="icon icon-edit"></span> |
| 324 <span class="i18n_options_customFilter_edit"></span> | 324 <span class="i18n_options_customFilter_edit"></span> |
| 325 </button> | 325 </button> |
| (...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 396 <label class="display"></label> | 396 <label class="display"></label> |
| 397 </template> | 397 </template> |
| 398 </ul> | 398 </ul> |
| 399 </div> | 399 </div> |
| 400 </div> | 400 </div> |
| 401 <!-- Add custom subscription --> | 401 <!-- Add custom subscription --> |
| 402 <div id="dialog-content-custom" class="dialog-content"> | 402 <div id="dialog-content-custom" class="dialog-content"> |
| 403 <div class="dialog-content-block"> | 403 <div class="dialog-content-block"> |
| 404 <div> | 404 <div> |
| 405 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label> | 405 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label> |
| 406 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" /> | 406 <input id="blockingList-textbox" type="url" required="true" patter n="https?://.+" class="default-focus" placeholder="https://example.com/blockingl ist.txt" /> |
|
Sebastian Noack
2016/04/06 22:46:01
Two notes here:
1. type=url only checks whether t
| |
| 407 </div> | 407 </div> |
| 408 <button class="i18n_options_dialog_custom_import" data-action="impor t-subscription"></button> | 408 <button class="i18n_options_dialog_custom_import" data-action="impor t-subscription"></button> |
| 409 </div> | 409 </div> |
| 410 <div class="dialog-content-block"> | 410 <div class="dialog-content-block"> |
| 411 <h3 class="i18n_options_dialog_edit_own_list"></h3> | 411 <h3 class="i18n_options_dialog_edit_own_list"></h3> |
| 412 <button class="i18n_options_dialog_create_own_list" data-action="clo se-dialog,switch-tab,edit-custom-filters" data-tab="advanced-customFilters"></bu tton> | 412 <button class="i18n_options_dialog_create_own_list" data-action="clo se-dialog,switch-tab,edit-custom-filters" data-tab="advanced-customFilters"></bu tton> |
| 413 </div> | 413 </div> |
| 414 </div> | 414 </div> |
| 415 <!-- Add predefined subscription --> | 415 <!-- Add predefined subscription --> |
| 416 <div id="dialog-content-predefined" class="dialog-content"> | 416 <div id="dialog-content-predefined" class="dialog-content"> |
| 417 <div class="dialog-content-block"> | 417 <div class="dialog-content-block"> |
| 418 <h3></h3> | 418 <h3></h3> |
| 419 <div class="url"></div> | 419 <div class="url"></div> |
| 420 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> | 420 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> |
| 421 </div> | 421 </div> |
| 422 </div> | 422 </div> |
| 423 </div> | 423 </div> |
| 424 <!-- Placeholder element to determine when to wrap focus around --> | 424 <!-- Placeholder element to determine when to wrap focus around --> |
| 425 <span class="focus-last" tabindex="0"></span> | 425 <span class="focus-last" tabindex="0"></span> |
| 426 </div> | 426 </div> |
| 427 </body> | 427 </body> |
| 428 </html> | 428 </html> |
| OLD | NEW |
