Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: options.html

Issue 29339527: Issue 3892 - Disable button if input is invalid when adding subscriptions or filters (Closed)
Patch Set: Created April 6, 2016, 10:43 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | options.js » ('j') | options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: options.html
===================================================================
--- a/options.html
+++ b/options.html
@@ -312,7 +312,7 @@
</template>
</ul>
<form id="custom-filters-add" class="controls">
- <input type="text"/>
+ <input type="text" required="true" pattern=".*\S.*"/>
<button class="i18n_options_button_add" type="submit"></button>
</form>
</div>
@@ -403,7 +403,7 @@
<div class="dialog-content-block">
<div>
<label for="blockingList-textbox" class="i18n_options_dialog_custom_subscription_title"></label>
- <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" />
+ <input id="blockingList-textbox" type="url" required="true" pattern="https?://.+" class="default-focus" placeholder="https://example.com/blockinglist.txt" />
Sebastian Noack 2016/04/06 22:46:01 Two notes here: 1. type=url only checks whether t
</div>
<button class="i18n_options_dialog_custom_import" data-action="import-subscription"></button>
</div>
« no previous file with comments | « no previous file | options.js » ('j') | options.js » ('J')

Powered by Google App Engine
This is Rietveld