Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(107)

Issue 29339548: Issue 3894 - Add tests for the update_issues hook (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Felix Dahlke
Modified:
3 years, 10 months ago
Reviewers:
Vasily Kuznetsov, kzar
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 3894 - Add tests for the update_issues hook Repository: adblockplus.org/sitescripts

Patch Set 1 #

Total comments: 11

Patch Set 2 : Addressed Vasily's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, --1 lines) Patch
A sitescripts/hg/test/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sitescripts/hg/test/update_issues.py View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Felix Dahlke
3 years, 10 months ago (2016-04-07 09:51:47 UTC) #1
Vasily Kuznetsov
Hi Felix, See below my comments. I think some of the issues that I saw ...
3 years, 10 months ago (2016-04-07 14:17:22 UTC) #2
Felix Dahlke
Thanks, new patch set is up. https://codereview.adblockplus.org/29339548/diff/29339549/sitescripts/hg/test/update_issues.py File sitescripts/hg/test/update_issues.py (right): https://codereview.adblockplus.org/29339548/diff/29339549/sitescripts/hg/test/update_issues.py#newcode21 sitescripts/hg/test/update_issues.py:21: def _create_mock_repo(node, message): ...
3 years, 10 months ago (2016-04-07 15:42:00 UTC) #3
Vasily Kuznetsov
LGTM https://codereview.adblockplus.org/29339548/diff/29339549/sitescripts/hg/test/update_issues.py File sitescripts/hg/test/update_issues.py (right): https://codereview.adblockplus.org/29339548/diff/29339549/sitescripts/hg/test/update_issues.py#newcode21 sitescripts/hg/test/update_issues.py:21: def _create_mock_repo(node, message): On 2016/04/07 15:42:00, Felix Dahlke ...
3 years, 10 months ago (2016-04-07 21:16:49 UTC) #4
kzar
3 years, 10 months ago (2016-04-13 12:56:29 UTC) #5
Sorry for the delay, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5