Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 29339552: Issue 3895 - Fix size of dialog close buttons on the options page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Sebastian Noack
Modified:
3 years, 10 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3895 - Fix size of dialog close buttons on the options page

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M skin/options.css View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
3 years, 10 months ago (2016-04-07 10:36:39 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29339552/diff/29339553/skin/options.css File skin/options.css (right): https://codereview.adblockplus.org/29339552/diff/29339553/skin/options.css#newcode1203 skin/options.css:1203: background-position: -9px -32px; Detail: These coordinates should be `-10px ...
3 years, 10 months ago (2016-04-07 17:40:11 UTC) #2
Sebastian Noack
On 2016/04/07 17:40:11, Thomas Greiner wrote: > https://codereview.adblockplus.org/29339552/diff/29339553/skin/options.css > File skin/options.css (right): > > https://codereview.adblockplus.org/29339552/diff/29339553/skin/options.css#newcode1203 ...
3 years, 10 months ago (2016-04-08 15:56:05 UTC) #3
Thomas Greiner
3 years, 10 months ago (2016-04-15 13:24:22 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5