Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: skin/options.css

Issue 29339552: Issue 3895 - Fix size of dialog close buttons on the options page (Closed)
Left Patch Set: Created April 7, 2016, 10:35 a.m.
Right Patch Set: Addressed comments Created April 8, 2016, 3:54 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 1182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1193 color: #0F660F; 1193 color: #0F660F;
1194 display: inline-block; 1194 display: inline-block;
1195 height: 20px; 1195 height: 20px;
1196 font-size: 15px; 1196 font-size: 15px;
1197 -moz-padding-start: 10px; 1197 -moz-padding-start: 10px;
1198 -webkit-padding-start: 10px; 1198 -webkit-padding-start: 10px;
1199 } 1199 }
1200 1200
1201 #dialog-close::before 1201 #dialog-close::before
1202 { 1202 {
1203 background-position: -9px -32px; 1203 background-position: -10px -33px;
Thomas Greiner 2016/04/07 17:40:11 Detail: These coordinates should be `-10px -33px`
1204 content: ""; 1204 content: "";
1205 cursor: pointer; 1205 cursor: pointer;
1206 height: 10px; 1206 height: 8px;
Thomas Greiner 2016/04/07 17:40:11 Detail: Actually, the "close" button in the sprite
1207 width: 10px; 1207 width: 8px;
1208 vertical-align: middle; 1208 vertical-align: middle;
1209 -moz-margin-end: 6px; 1209 -moz-margin-end: 6px;
1210 -webkit-margin-end: 6px; 1210 -webkit-margin-end: 6px;
1211 } 1211 }
1212 1212
1213 #dialog #dialog-body 1213 #dialog #dialog-body
1214 { 1214 {
1215 margin: 4px 24px; 1215 margin: 4px 24px;
1216 } 1216 }
1217 1217
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
1322 #other-language .button-add::before 1322 #other-language .button-add::before
1323 { 1323 {
1324 display: none; 1324 display: none;
1325 } 1325 }
1326 1326
1327 #other-language .display 1327 #other-language .display
1328 { 1328 {
1329 -webkit-margin-start: 10px; 1329 -webkit-margin-start: 10px;
1330 -moz-margin-start: 10px; 1330 -moz-margin-start: 10px;
1331 } 1331 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld