Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339619: Issue 3909 - Move "Tweaks" below "Filter lists" on options page (Closed)

Created:
April 8, 2016, 6:57 p.m. by Sebastian Noack
Modified:
Feb. 20, 2017, 11:47 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 3909 - Move "Tweaks" below "Filter lists" on options page

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -35 lines) Patch
M options.html View 2 chunks +34 lines, -34 lines 0 comments Download
M options.js View 1 chunk +22 lines, -1 line 3 comments Download

Messages

Total messages: 3
Sebastian Noack
April 8, 2016, 6:58 p.m. (2016-04-08 18:58:02 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29339619/diff/29339620/options.js File options.js (right): https://codereview.adblockplus.org/29339619/diff/29339620/options.js#newcode1117 options.js:1117: var tabs = document.querySelectorAll("nav [id^=tab-]"); Instead of manually checking ...
April 11, 2016, 6:34 p.m. (2016-04-11 18:34:40 UTC) #2
Sebastian Noack
Feb. 20, 2017, 11:06 a.m. (2017-02-20 11:06:43 UTC) #3
Message was sent while issue was closed.
I closed this review without landing the changes, as the design those changes
were based on, is deprecated.

Powered by Google App Engine
This is Rietveld