Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339642: Issue 3914 - Update links in web.adblockplus.org for new EasyList website (Closed)

Created:
April 11, 2016, 3:18 p.m. by saroyanm
Modified:
April 13, 2016, 2:09 p.m.
Reviewers:
juliandoucette
Visibility:
Public.

Description

Issue 3914 - Update links in web.adblockplus.org for new EasyList website There is another link in translation file I'll align about that with Tamara end update the string after running Translation Synchronization script: https://hg.adblockplus.org/web.adblockplus.org/file/tip/locales/fr/features.json#l15

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pages/about.html View 1 chunk +1 line, -1 line 2 comments Download
M pages/faq_troubleshooting.html View 1 chunk +1 line, -1 line 0 comments Download
M pages/features.html View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
saroyanm
Julian can you please have a look when you have time ? It's again a ...
April 11, 2016, 3:25 p.m. (2016-04-11 15:25:27 UTC) #1
juliandoucette
LGTM https://codereview.adblockplus.org/29339642/diff/29339643/pages/about.html File pages/about.html (right): https://codereview.adblockplus.org/29339642/diff/29339643/pages/about.html#newcode76 pages/about.html:76: {{EasyListdefined EasyList corresponds to your browser language and ...
April 13, 2016, 12:09 p.m. (2016-04-13 12:09:01 UTC) #2
saroyanm
April 13, 2016, 1:55 p.m. (2016-04-13 13:55:54 UTC) #3
https://codereview.adblockplus.org/29339642/diff/29339643/pages/about.html
File pages/about.html (right):

https://codereview.adblockplus.org/29339642/diff/29339643/pages/about.html#ne...
pages/about.html:76: {{EasyListdefined EasyList corresponds to your browser
language and is aimed at disabling ads that are considered to be intrusive by
our community of users. Eyeo GmbH <strong>did not</strong> draft EasyList and
therefore has no right to, or control over, its content. Visit the <a
href="https://easylist.github.io/">EasyList Community</a> for more
information.}}
On 2016/04/13 12:09:01, juliandoucette wrote:
> Doesn't the label "Easylist Community" imply the forums not the website? 
> 
> (PS: This issue is a separate issue, thus non-blocking)

The old website had links to 2 different forums, also it had a blog where people
could leave their comments. 
I'll align with Arthur about what is the plan for the new website maybe it will
behave as a community and will host forum in the same website as well, thanks
for pointing that out.

Powered by Google App Engine
This is Rietveld