Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339651: Issue 3915 - Avoid listing special subscriptions (Closed)

Created:
April 12, 2016, 12:09 p.m. by kzar
Modified:
April 14, 2016, 9:44 a.m.
Visibility:
Public.

Description

Issue 3915 - Avoid listing special subscriptions

Patch Set 1 #

Total comments: 1

Patch Set 2 : Avoid listing special subscriptions #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M messageResponder.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M options.js View 1 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 3
kzar
Patch Set 1
April 12, 2016, 12:10 p.m. (2016-04-12 12:10:57 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29339651/diff/29339652/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29339651/diff/29339652/messageResponder.js#newcode75 messageResponder.js:75: obj.special = subscription instanceof SpecialSubscription; As suggest on the ...
April 12, 2016, 12:21 p.m. (2016-04-12 12:21:34 UTC) #2
kzar
April 13, 2016, 8:05 a.m. (2016-04-13 08:05:11 UTC) #3
Patch Set 2 : Avoid listing special subscriptions

https://codereview.adblockplus.org/29339651/diff/29339669/options.js
File options.js (right):

https://codereview.adblockplus.org/29339651/diff/29339669/options.js#newcode958
options.js:958: if (subscription.isSpecial)
Note: I wasn't sure how to test this.

Powered by Google App Engine
This is Rietveld