Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29339710: Issue 3919 - Added missing flags (el, it, ja, pl, pt_PT) (Closed)

Created:
April 13, 2016, 3:28 p.m. by saroyanm
Modified:
Sept. 22, 2016, 2:29 p.m.
Reviewers:
juliandoucette
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 3919 - Added missing flags (el, it, ja, pl, pt_PT)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M static/css/main.css View 3 chunks +25 lines, -0 lines 0 comments Download
M static/img/sprite-flags.png View Binary file 0 comments Download

Messages

Total messages: 4
saroyanm
Julian can you please have a look, when you have time.
April 13, 2016, 3:34 p.m. (2016-04-13 15:34:21 UTC) #1
juliandoucette
LGTM
April 19, 2016, 6:03 p.m. (2016-04-19 18:03:03 UTC) #2
juliandoucette
On 2016/04/19 18:03:03, juliandoucette wrote: > LGTM - did you push this? - will you ...
Sept. 22, 2016, 2:06 p.m. (2016-09-22 14:06:37 UTC) #3
saroyanm
Sept. 22, 2016, 2:27 p.m. (2016-09-22 14:27:58 UTC) #4
On 2016/09/22 14:06:37, juliandoucette wrote:
> On 2016/04/19 18:03:03, juliandoucette wrote:
> > LGTM
> 
> - did you push this?
No I didn't, because I had to revert translations:
https://issues.adblockplus.org/ticket/3959 
> - will you close this?
I'll push the changes so we can in future or translate homepage to that
languages as well and already have the flags, or fix #3959

Powered by Google App Engine
This is Rietveld