Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(283)

Issue 29339714: Issue 3924 - Notice pages loaded from Safari's page cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by kzar
Modified:
3 years, 5 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3924 - Notice pages loaded from Safari's page cache

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M safari/ext/content.js View 1 chunk +32 lines, -14 lines 1 comment Download

Messages

Total messages: 2
kzar
Patch Set 1
3 years, 5 months ago (2016-04-14 08:58:55 UTC) #1
Sebastian Noack
3 years, 5 months ago (2016-04-14 10:58:56 UTC) #2
LGTM with the nit addressed.

https://codereview.adblockplus.org/29339714/diff/29339715/safari/ext/content.js
File safari/ext/content.js (right):

https://codereview.adblockplus.org/29339714/diff/29339715/safari/ext/content....
safari/ext/content.js:57: window.addEventListener("pageshow", function (event)
Nit: Redundant space after function statement.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5