Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29340492: Issue 3950 - Extend the Python coding practices (Closed)

Created:
April 18, 2016, 11:17 a.m. by Sebastian Noack
Modified:
April 27, 2016, 9:34 a.m.
Reviewers:
Vasily Kuznetsov
CC:
kzar, Felix Dahlke
Visibility:
Public.

Description

Issue 3950 - Extend the Python coding practices

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improved texts as discussed with Vasily #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pages/coding-style.html View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
https://codereview.adblockplus.org/29340492/diff/29340493/pages/coding-style.html File pages/coding-style.html (left): https://codereview.adblockplus.org/29340492/diff/29340493/pages/coding-style.html#oldcode15 pages/coding-style.html:15: <li>{{s7 Use 2 spaces per indentation level.}}</li> As we ...
April 18, 2016, 11:20 a.m. (2016-04-18 11:20:10 UTC) #1
Vasily Kuznetsov
April 18, 2016, 12:18 p.m. (2016-04-18 12:18:33 UTC) #2
LGTM (as per Patch Set 2).

Powered by Google App Engine
This is Rietveld