metadata.chrome - Issue 29340571: Issue 3687 - Add experimental support for Safari content blockers

Side by Side Diff: metadata.chrome

Issue 29340571: Issue 3687 - Add experimental support for Safari content blockers (Closed)

Patch Set: Created April 19, 2016, 1:59 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [default]	1 [default]

2 inherit = metadata.common	2 inherit = metadata.common

3	3

4 [general]	4 [general]

5 basename = adblockpluschrome	5 basename = adblockpluschrome

6 permissions = tabs	6 permissions = tabs

7 http:///	7 http:///

8 https:///	8 https:///

9 contextMenus	9 contextMenus

10 webRequest	10 webRequest

(...skipping 22 matching lines...) Expand all Loading...
33 icons/abp-38-notification-critical.png = chrome/icons/abp-38-notification-critic al.png	33 icons/abp-38-notification-critical.png = chrome/icons/abp-38-notification-critic al.png

34 icons/abp-38-notification-information.png = chrome/icons/abp-38-notification-inf ormation.png	34 icons/abp-38-notification-information.png = chrome/icons/abp-38-notification-inf ormation.png

35 icons/detailed/abp-48.png = chrome/icons/detailed/abp-48.png	35 icons/detailed/abp-48.png = chrome/icons/detailed/abp-48.png

36 ext/devtools.js = chrome/ext/devtools.js	36 ext/devtools.js = chrome/ext/devtools.js

37 devtools.html = chrome/devtools.html	37 devtools.html = chrome/devtools.html

38 devtools.js = chrome/devtools.js	38 devtools.js = chrome/devtools.js

39 devtools-panel.html = adblockplusui/devtools-panel.html	39 devtools-panel.html = adblockplusui/devtools-panel.html

40 devtools-panel.js = adblockplusui/devtools-panel.js	40 devtools-panel.js = adblockplusui/devtools-panel.js

41 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css	41 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css

42 managed-storage-schema.json = chrome/managed-storage-schema.json	42 managed-storage-schema.json = chrome/managed-storage-schema.json

	43

	44 [convert_js]

	45 lib/adblockplus.js -= abp2blocklist/lib/abp2blocklist.js safari/contentBlocking. js
	kzar 2016/04/19 14:03:49 I'm guessing there's a better way to achieve the s I'm guessing there's a better way to achieve the same thing, any suggestions? Sebastian Noack 2016/05/12 11:12:22 I agree that it's kinda backwards to remove script Show quoted text On 2016/04/19 14:03:49, kzar wrote: > I'm guessing there's a better way to achieve the same thing, any suggestions? I agree that it's kinda backwards to remove scripts that are only necessary for one platform in the configuration for another platform. However, since the convert_js options take some arguments that need to be given in the end, we cannot append to those options. However, feel free to change the logic in buildtools to make stuff like this more straight-forward. But how it's currently implemented this is the only way to do it. kzar 2016/05/17 15:15:36 Acknowledged. (Considering time constraints I will Show quoted text On 2016/05/12 11:12:22, Sebastian Noack wrote: > On 2016/04/19 14:03:49, kzar wrote: > > I'm guessing there's a better way to achieve the same thing, any suggestions? > > I agree that it's kinda backwards to remove scripts that are only necessary for > one platform in the configuration for another platform. However, since the > convert_js options take some arguments that need to be given in the end, we > cannot append to those options. However, feel free to change the logic in > buildtools to make stuff like this more straight-forward. But how it's currently > implemented this is the only way to do it. Acknowledged. (Considering time constraints I will leave this as-is for now.) Sebastian Noack 2016/05/17 18:35:24 Feel free to file an issue though. I like the idea Show quoted text On 2016/05/17 15:15:36, kzar wrote: > On 2016/05/12 11:12:22, Sebastian Noack wrote: > > On 2016/04/19 14:03:49, kzar wrote: > > > I'm guessing there's a better way to achieve the same thing, any > suggestions? > > > > I agree that it's kinda backwards to remove scripts that are only necessary > for > > one platform in the configuration for another platform. However, since the > > convert_js options take some arguments that need to be given in the end, we > > cannot append to those options. However, feel free to change the logic in > > buildtools to make stuff like this more straight-forward. But how it's > currently > > implemented this is the only way to do it. > > Acknowledged. (Considering time constraints I will leave this as-is for now.) Feel free to file an issue though. I like the idea, and perhaps it's something for Jon. FWIW, I think this would be a more reasonable way to specify the options, wouldn't insist though: [convert_js] lib/adblockplus.js = <input files> lib/adblockplus.js:module = true lib/adblockplus.js:source_repo = https://hg.adblockplus.org/adblockpluscore/ kzar 2016/05/17 19:20:21 There you go https://issues.adblockplus.org/ticket Show quoted text On 2016/05/17 18:35:24, Sebastian Noack wrote: > On 2016/05/17 15:15:36, kzar wrote: > > On 2016/05/12 11:12:22, Sebastian Noack wrote: > > > On 2016/04/19 14:03:49, kzar wrote: > > > > I'm guessing there's a better way to achieve the same thing, any > > suggestions? > > > > > > I agree that it's kinda backwards to remove scripts that are only necessary > > for > > > one platform in the configuration for another platform. However, since the > > > convert_js options take some arguments that need to be given in the end, we > > > cannot append to those options. However, feel free to change the logic in > > > buildtools to make stuff like this more straight-forward. But how it's > > currently > > > implemented this is the only way to do it. > > > > Acknowledged. (Considering time constraints I will leave this as-is for now.) > > Feel free to file an issue though. I like the idea, and perhaps it's something > for Jon. > > FWIW, I think this would be a more reasonable way to specify the options, > wouldn't insist though: > > [convert_js] > lib/adblockplus.js = <input files> > lib/adblockplus.js:module = true > lib/adblockplus.js:source_repo = https://hg.adblockplus.org/adblockpluscore/ There you go https://issues.adblockplus.org/ticket/4047 Sebastian Noack 2016/05/18 07:03:29 Thanks! Show quoted text On 2016/05/17 19:20:21, kzar wrote: > On 2016/05/17 18:35:24, Sebastian Noack wrote: > > On 2016/05/17 15:15:36, kzar wrote: > > > On 2016/05/12 11:12:22, Sebastian Noack wrote: > > > > On 2016/04/19 14:03:49, kzar wrote: > > > > > I'm guessing there's a better way to achieve the same thing, any > > > suggestions? > > > > > > > > I agree that it's kinda backwards to remove scripts that are only > necessary > > > for > > > > one platform in the configuration for another platform. However, since the > > > > convert_js options take some arguments that need to be given in the end, > we > > > > cannot append to those options. However, feel free to change the logic in > > > > buildtools to make stuff like this more straight-forward. But how it's > > > currently > > > > implemented this is the only way to do it. > > > > > > Acknowledged. (Considering time constraints I will leave this as-is for > now.) > > > > Feel free to file an issue though. I like the idea, and perhaps it's something > > for Jon. > > > > FWIW, I think this would be a more reasonable way to specify the options, > > wouldn't insist though: > > > > [convert_js] > > lib/adblockplus.js = <input files> > > lib/adblockplus.js:module = true > > lib/adblockplus.js:source_repo = https://hg.adblockplus.org/adblockpluscore/ > > There you go https://issues.adblockplus.org/ticket/4047 Thanks!
OLD	NEW

« _locales/en_US/messages.json ('K') | « lib/url.js ('k') | metadata.common » ('j') | metadata.common » ('J')