metadata.common - Issue 29340571: Issue 3687 - Add experimental support for Safari content blockers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 29340571: Issue 3687 - Add experimental support for Safari content blockers (Closed)

Left Patch Set: Created April 19, 2016, 1:59 p.m.

Right Patch Set: Addressed Nits Created May 18, 2016, 11:30 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.11	2 version = 1.11

3 backgroundScripts = lib/polyfills/url.js	3 backgroundScripts = lib/polyfills/url.js

4 lib/polyfills/promise.js	4 lib/polyfills/promise.js

5 lib/polyfills/fetch.js	5 lib/polyfills/fetch.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/info.js	9 lib/info.js

10 lib/publicSuffixList.js	10 lib/publicSuffixList.js

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91 lib/devtools.js	91 lib/devtools.js

92 lib/whitelisting.js	92 lib/whitelisting.js

93 lib/filterValidation.js	93 lib/filterValidation.js

94 lib/filterComposer.js	94 lib/filterComposer.js

95 lib/icon.js	95 lib/icon.js

96 lib/notificationHelper.js	96 lib/notificationHelper.js

97 lib/subscriptionInit.js	97 lib/subscriptionInit.js

98 lib/requestBlocker.js	98 lib/requestBlocker.js

99 lib/popupBlocker.js	99 lib/popupBlocker.js

100 lib/uninstall.js	100 lib/uninstall.js

101 lib/punycode.js	101 lib/punycode.js
Sebastian Noack 2016/05/12 11:12:22 So you wrap punycode.js into a module, however it So you wrap punycode.js into a module, however it still defines a global that is used by most of our code? Perhaps we should prevent it from creating a global, and always use it as a module? kzar 2016/05/17 15:15:37 Hmm guess you're right, Done. Show quoted text On 2016/05/12 11:12:22, Sebastian Noack wrote: > So you wrap punycode.js into a module, however it still defines a global that is > used by most of our code? Perhaps we should prevent it from creating a global, > and always use it as a module? Hmm guess you're right, Done.
102 abp2blocklist/lib/abp2blocklist.js	102 abp2blocklist/lib/abp2blocklist.js

103 safari/contentBlocking.js	103 safari/contentBlocking.js

104 --arg module=true source_repo=https://hg.adblockplus.org/adblockpluscore/	104 --arg module=true source_repo=https://hg.adblockplus.org/adblockpluscore/

105 ext/common.js = ext/common.js chrome/ext/common.js	105 ext/common.js = ext/common.js chrome/ext/common.js

106 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand	106 ext/background.js = ext/background.js chrome/ext/background.js --arg brace_style =expand

107 include.postload.js = subscriptionLink.postload.js composer.postload.js	107 include.postload.js = subscriptionLink.postload.js composer.postload.js

108	108

109 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js	109 qunit/tests/adblockplus.js = adblockplustests/chrome/content/tests/domainRestric tions.js

110 adblockplustests/chrome/content/tests/filterClasses.js	110 adblockplustests/chrome/content/tests/filterClasses.js

111 adblockplustests/chrome/content/tests/filterNotifier.js	111 adblockplustests/chrome/content/tests/filterNotifier.js

(...skipping 30 matching lines...) Expand all Loading...
142 addSubscription.label	142 addSubscription.label

143 addSubscriptionAdd.label	143 addSubscriptionAdd.label

144 addSubscriptionOther.label	144 addSubscriptionOther.label

145 acceptableAds2.label	145 acceptableAds2.label

146 viewList.label	146 viewList.label

147 readMore.label	147 readMore.label

148 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	148 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

149 title.label	149 title.label

150 adblockplus/chrome/locale/*/meta.properties = =name	150 adblockplus/chrome/locale/*/meta.properties = =name

151 adblockplusui/locale//firstRun.json = =	151 adblockplusui/locale//firstRun.json = =

152 adblockplusui/locale//options.json = =

LEFT	RIGHT