metadata.common - Issue 29340571: Issue 3687 - Add experimental support for Safari content blockers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 29340571: Issue 3687 - Add experimental support for Safari content blockers (Closed)

Left Patch Set: Remove onChange logic for checkboxes Created May 18, 2016, 10:43 a.m.

Right Patch Set: Addressed Nits Created May 18, 2016, 11:30 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 version = 1.11	2 version = 1.11

3 backgroundScripts = lib/polyfills/url.js	3 backgroundScripts = lib/polyfills/url.js

4 lib/polyfills/promise.js	4 lib/polyfills/promise.js

5 lib/polyfills/fetch.js	5 lib/polyfills/fetch.js

6 ext/common.js	6 ext/common.js

7 ext/background.js	7 ext/background.js

8 lib/compat.js	8 lib/compat.js

9 lib/info.js	9 lib/info.js

10 lib/publicSuffixList.js	10 lib/publicSuffixList.js

(...skipping 130 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
141 subscription.delete.label	141 subscription.delete.label

142 addSubscription.label	142 addSubscription.label

143 addSubscriptionAdd.label	143 addSubscriptionAdd.label

144 addSubscriptionOther.label	144 addSubscriptionOther.label

145 acceptableAds2.label	145 acceptableAds2.label

146 viewList.label	146 viewList.label

147 readMore.label	147 readMore.label

148 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	148 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

149 title.label	149 title.label

150 adblockplus/chrome/locale/*/meta.properties = =name	150 adblockplus/chrome/locale/*/meta.properties = =name

151 adblockplusui/locale//firstRun.json = =	151 adblockplusui/locale//firstRun.json = =
Sebastian Noack 2016/05/18 11:16:32 Nit: It seems you removed the new line at the end Nit: It seems you removed the new line at the end of the file. kzar 2016/05/18 11:32:07 Done. Show quoted text On 2016/05/18 11:16:32, Sebastian Noack wrote: > Nit: It seems you removed the new line at the end of the file. Done.
LEFT	RIGHT